Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned and updated Makefiles #280

Merged
merged 1 commit into from May 20, 2018
Merged

Cleaned and updated Makefiles #280

merged 1 commit into from May 20, 2018

Conversation

@FireEmerald
Copy link
Collaborator

@FireEmerald FireEmerald commented May 18, 2018

Make.bat

  • Added -legacy switch to force use of VS2015, instead of VS2017 or later
  • Added ability to build without markdown-html
  • Replaced hard coded Visual Studio paths with vswhere
  • Removed unused releaseVersion detection
  • Removed unused sign functionality as the installer is doing this now

Make-Installer.bat

  • Replaced hard coded Inno Setup paths with registry value

Most errors are now shown correctly or avoided

Make.bat
- Added -legacy switch to force use of VS2015, instead of VS2017 or later
- Added ability to build without markdown-html
- Replaced hard coded Visual Studio paths with vswhere
- Removed unused releaseVersion detection
- Removed unused sign functionality as the installer is doing this now

Make-Installer.bat
- Replaced hard coded Inno Setup paths with registry value

Most errors are now shown correctly or avoided
@FireEmerald FireEmerald requested a review from Belphemur May 18, 2018
@Belphemur
Copy link
Owner

@Belphemur Belphemur commented May 20, 2018

Nice cleanup of the build tool !

@Belphemur Belphemur merged commit aa1f3ba into dev May 20, 2018
@FireEmerald FireEmerald deleted the feature/ImproveMakefiles branch May 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants