Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argument dict #124

Merged
merged 2 commits into from Mar 17, 2020
Merged

Add argument dict #124

merged 2 commits into from Mar 17, 2020

Conversation

@luh0907
Copy link
Contributor

luh0907 commented Mar 17, 2020

Now user can indicate what dictionary to use, by an argument like --dict [PATH_TO_DICT].txt.
Related issue: #123

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 17, 2020

Codecov Report

Merging #124 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #124   +/-   ##
=======================================
  Coverage   70.50%   70.50%           
=======================================
  Files          12       12           
  Lines         512      512           
=======================================
  Hits          361      361           
  Misses        151      151           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a74f738...85e6988. Read the comment docs.

@Belval Belval self-requested a review Mar 17, 2020
@Belval
Belval approved these changes Mar 17, 2020
Copy link
Owner

Belval left a comment

LGTM

@Belval Belval merged commit ee0bdb4 into Belval:master Mar 17, 2020
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Belval

This comment has been minimized.

Copy link
Owner

Belval commented Mar 17, 2020

Thank you for this very useful PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.