Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add split on words instead of split on characters #126

Merged
merged 4 commits into from Mar 25, 2020
Merged

Conversation

@Belval
Copy link
Owner

Belval commented Mar 25, 2020

Fixes #122

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 25, 2020

Codecov Report

Merging #126 into master will increase coverage by 0.56%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
+ Coverage   70.48%   71.04%   +0.56%     
==========================================
  Files          12       12              
  Lines         515      525      +10     
==========================================
+ Hits          363      373      +10     
  Misses        152      152
Impacted Files Coverage Δ
trdg/generators/from_wikipedia.py 88.88% <ø> (ø) ⬆️
trdg/generators/from_dict.py 89.47% <ø> (ø) ⬆️
trdg/data_generator.py 76.19% <ø> (ø) ⬆️
trdg/generators/from_random.py 90.9% <ø> (ø) ⬆️
trdg/generators/from_strings.py 97.43% <100%> (+0.06%) ⬆️
trdg/computer_text_generator.py 98.21% <100%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72beeef...7d1d7c3. Read the comment docs.

@Belval Belval force-pushed the add-split-on-word branch from bd9b9ed to d01b723 Mar 25, 2020
@Belval Belval force-pushed the add-split-on-word branch from 0f0d8cc to 7d1d7c3 Mar 25, 2020
@Belval Belval merged commit 7d2449f into master Mar 25, 2020
1 check passed
1 check passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
@Belval Belval deleted the add-split-on-word branch Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.