Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use diff instead of MD5 for tests #127

Merged
merged 2 commits into from Mar 25, 2020
Merged

Use diff instead of MD5 for tests #127

merged 2 commits into from Mar 25, 2020

Conversation

@Belval
Copy link
Owner

Belval commented Mar 25, 2020

Use MD5 for comparison was a pain because it would yield inconsistent results based on the systems PNG and JPEG libraries.

Using diffimg allows us to do a more forgiving matching, which will still trigger on different images while allowing some differences.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 25, 2020

Codecov Report

Merging #127 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #127   +/-   ##
=======================================
  Coverage   70.48%   70.48%           
=======================================
  Files          12       12           
  Lines         515      515           
=======================================
  Hits          363      363           
  Misses        152      152

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f28e1dc...94933da. Read the comment docs.

@Belval Belval merged commit 72beeef into master Mar 25, 2020
1 check passed
1 check passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
@Belval Belval deleted the diff-instead-of-md5 branch Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.