Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argument font #60

Merged
merged 3 commits into from May 15, 2019

Conversation

Projects
None yet
3 participants
@JulienCoutault
Copy link
Contributor

commented May 15, 2019

As said in #59 : we can generate picture with only one font pass by argument

@codecov-io

This comment has been minimized.

Copy link

commented May 15, 2019

Codecov Report

Merging #60 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #60   +/-   ##
=======================================
  Coverage   65.25%   65.25%           
=======================================
  Files           6        6           
  Lines         354      354           
=======================================
  Hits          231      231           
  Misses        123      123

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06d987b...29656c1. Read the comment docs.

@Belval
Copy link
Owner

left a comment

Just add a test to the tests.py and it will be good to go.

type=str,
nargs="?",
help="Define font to be used",
default=""

This comment has been minimized.

Copy link
@Belval

Belval May 15, 2019

Owner

I'd remove that line, it'll default to None.

JulienCoutault added some commits May 15, 2019

@JulienCoutault

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

I add check to verify if file exist and I updated tests.py

@Belval

Belval approved these changes May 15, 2019

Copy link
Owner

left a comment

LGTM, you can merge it.

@Belval Belval merged commit 3414a65 into Belval:master May 15, 2019

4 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch Coverage not affected when comparing 06d987b...29656c1
Details
codecov/project 65.25% remains the same compared to 06d987b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Belval Belval referenced this pull request May 15, 2019

Closed

Add argument font in run.py #59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.