New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhelpful Error Message Regarding Curley Braces #213

Closed
reustle opened this Issue Sep 25, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@reustle
Contributor

reustle commented Sep 25, 2016

For example, if you use the following string as a format string $ without any numbers or parens, you get the following error message:

numbro.min.js:76 Uncaught Error: Format should also contain a "{"

I didn't realize I forgot to use $0,0 but the error message seemed odd. Maybe it should instead say something about missing the value placeholder?

@BenjaminVanRyseghem

This comment has been minimized.

Show comment
Hide comment
@BenjaminVanRyseghem

BenjaminVanRyseghem Sep 26, 2016

Owner

sounds like a good improvement indeed 😄

Owner

BenjaminVanRyseghem commented Sep 26, 2016

sounds like a good improvement indeed 😄

BenjaminVanRyseghem added a commit that referenced this issue Oct 20, 2016

Merge pull request #216 from reustle/develop
Fixed #213, Unhelpful Error Message with $ as Format String
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment