Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spaceSeparated is not working - version 2.0.5 #411

Closed
RichColours opened this issue Mar 7, 2019 · 5 comments
Closed

spaceSeparated is not working - version 2.0.5 #411

RichColours opened this issue Mar 7, 2019 · 5 comments

Comments

@RichColours
Copy link

RichColours commented Mar 7, 2019

Same symptoms as on your main webpage:

https://numbrojs.com/format.html#bytes

the spaceSeparated is not doing anything.

image

In my particular issue:

const size = numbro(x.sizeBytes).format({
spaceSeparated: true,
output: "byte",
base: "decimal",
mantissa: 1
});

        return `<tr><td>${x.filename}</td><td>${x.dateModifiedHuman}</td><td>${size}</td><td>${x.md5sum}</td></tr>`;

(apologies, GitHub's 'code' delimiter is Javascript's third type of string literal with escaping operator.

My output string is:

image

@RichColours
Copy link
Author

RichColours commented Mar 7, 2019

It is working on percentages though.

@kruthoff
Copy link

kruthoff commented Jun 17, 2020

I have the same issue on the latest version, currently 2.3.0. Any chance to get this fixed?

@BenjaminVanRyseghem
Copy link
Owner

BenjaminVanRyseghem commented Jun 17, 2020

in 2.3.1

@BenjaminVanRyseghem
Copy link
Owner

BenjaminVanRyseghem commented Jun 17, 2020

@all-contributors please add @RichColours for bug

@allcontributors
Copy link
Contributor

allcontributors bot commented Jun 17, 2020

@BenjaminVanRyseghem

I've put up a pull request to add @RichColours! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants