Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid thousand separator for de-CH #414

Closed
FrEaKmAn opened this issue Mar 27, 2019 · 4 comments
Closed

Invalid thousand separator for de-CH #414

FrEaKmAn opened this issue Mar 27, 2019 · 4 comments

Comments

@FrEaKmAn
Copy link

@FrEaKmAn FrEaKmAn commented Mar 27, 2019

Based on http://www.localeplanet.com/icu/de-CH/index.html and http://cldr.unicode.org/, thousand separator for de-CH must be

(\u2019)

instead of

' (\u0027)

@BenjaminVanRyseghem

This comment has been minimized.

Copy link
Owner

@BenjaminVanRyseghem BenjaminVanRyseghem commented Mar 27, 2019

thanks!

@FrEaKmAn

This comment has been minimized.

Copy link
Author

@FrEaKmAn FrEaKmAn commented Mar 27, 2019

@BenjaminVanRyseghem thanks for quick reply, I can provide PR if you have time for merge?

@BenjaminVanRyseghem

This comment has been minimized.

Copy link
Owner

@BenjaminVanRyseghem BenjaminVanRyseghem commented Mar 27, 2019

that would be awesome 😄

@BenjaminVanRyseghem

This comment has been minimized.

Copy link
Owner

@BenjaminVanRyseghem BenjaminVanRyseghem commented Mar 18, 2020

in numbro 2.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.