Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formatCurrency - forceSign doesn't work properly when number is positive #418

Closed
adriang133 opened this issue Apr 9, 2019 · 4 comments · Fixed by #420
Closed

formatCurrency - forceSign doesn't work properly when number is positive #418

adriang133 opened this issue Apr 9, 2019 · 4 comments · Fixed by #420

Comments

@adriang133
Copy link
Contributor

adriang133 commented Apr 9, 2019

numbro(1000).formatCurrency({forceSign: true}) -> $+1000
numbro(-1000).formatCurrency({forceSign: true}) -> -$1000

I would expect the first one to be +$1000

@Kramy
Copy link

Kramy commented Apr 11, 2019

Same problem here. Tested with en-Gb and en-AM locales.
Try it

@firebotQL
Copy link

firebotQL commented Jul 23, 2019

Hi, I am currently having this issue as well. I've noticed there is a PR hanging since April for this issue by @adriang133 . Any idea when it will be merged and released @BenjaminVanRyseghem? Thanks

@BenjaminVanRyseghem
Copy link
Owner

BenjaminVanRyseghem commented Jul 24, 2019

Sorry, I am a bit off those days. Between a new job and a newborn, I am a bit running after free time 😄

@BenjaminVanRyseghem
Copy link
Owner

BenjaminVanRyseghem commented Mar 18, 2020

in numbro 2.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants