It looks like npm test never fails. After adding a failing test I still get the same result:
...
[13:15:10] Finished 'build' after 11 s
[13:15:10] Finished 'test:integration:amd' after 11 s
[13:15:10] Finished 'test:integration' after 11 s
[13:15:10] Finished 'test' after 11 s
[13:15:10] Finished 'test' after 11 s
$
Then when running npm run coverage I get the following error:
$ npm run coverage
...
[Validate language] Invalid key: bytes
...
Error: Invalid language data
at Object.state.registerLanguage (/Users/agreco/adev/numbro/src/globalState.js:9:4668)
on master, coverage is fine, but tests still pass even when adding a failing test.
I think the newest byte translation patch has some test failures that were missed because the tests are always passing.
It looks like
npm testnever fails. After adding a failing test I still get the same result:Then when running
npm run coverageI get the following error:on
master, coverage is fine, but tests still pass even when adding a failing test.I think the newest byte translation patch has some test failures that were missed because the tests are always passing.