Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests always pass & coverage fails in develop branch #474

Closed
austingreco opened this issue Apr 4, 2020 · 2 comments
Closed

Tests always pass & coverage fails in develop branch #474

austingreco opened this issue Apr 4, 2020 · 2 comments

Comments

@austingreco
Copy link
Contributor

austingreco commented Apr 4, 2020

It looks like npm test never fails. After adding a failing test I still get the same result:

...
[13:15:10] Finished 'build' after 11 s
[13:15:10] Finished 'test:integration:amd' after 11 s
[13:15:10] Finished 'test:integration' after 11 s
[13:15:10] Finished 'test' after 11 s
[13:15:10] Finished 'test' after 11 s
$ 

Then when running npm run coverage I get the following error:

$ npm run coverage
...
[Validate language] Invalid key: bytes
...
Error: Invalid language data
    at Object.state.registerLanguage (/Users/agreco/adev/numbro/src/globalState.js:9:4668)

on master, coverage is fine, but tests still pass even when adding a failing test.

I think the newest byte translation patch has some test failures that were missed because the tests are always passing.

@BenjaminVanRyseghem
Copy link
Owner

BenjaminVanRyseghem commented Apr 4, 2020

Thanks for catching this one!!!!!!

I fixed the gulp part (test always passing) and will review your PR!

@BenjaminVanRyseghem
Copy link
Owner

BenjaminVanRyseghem commented May 30, 2020

in numbro 2.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants