Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add de-AT localization #239

Merged
merged 1 commit into from Mar 28, 2017
Merged

Conversation

@gwynjudd
Copy link
Contributor

@gwynjudd gwynjudd commented Mar 24, 2017

I have a number of other localizations available, but I just want to see if I can get everything right with this one as a test before working on the others. It is translated from a localization we did for numeral.js so I want to look out for anything missing there.

@BenjaminVanRyseghem
Copy link
Owner

@BenjaminVanRyseghem BenjaminVanRyseghem commented Mar 24, 2017

why 2 commits with the same short description?

@gwynjudd
Copy link
Contributor Author

@gwynjudd gwynjudd commented Mar 24, 2017

That was my mistake I should have squashed the commits together. I'll have to fix it up on Monday when I get in to work.

When I submit a localisation in not sure what bits are required, is it enough just the languages/xx.js and the tests/languages/xx.js?

@BenjaminVanRyseghem
Copy link
Owner

@BenjaminVanRyseghem BenjaminVanRyseghem commented Mar 24, 2017

the file + tests should be enough (as we dist for releases)

Now, if you provide a dist, it can potentially be used by people using bleeding-edge 😄

@gwynjudd
Copy link
Contributor Author

@gwynjudd gwynjudd commented Mar 24, 2017

Ok I'll keep that in mind for next time

@gwynjudd gwynjudd force-pushed the gwynjudd:de-AT branch from 31694d8 to d322bf5 Mar 26, 2017
@gwynjudd gwynjudd force-pushed the gwynjudd:de-AT branch from ae932b7 to 2ca734a Mar 27, 2017
@BenjaminVanRyseghem BenjaminVanRyseghem merged commit 8949079 into BenjaminVanRyseghem:develop Mar 28, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gwynjudd gwynjudd deleted the gwynjudd:de-AT branch Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.