New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add de-AT localization #239

Merged
merged 1 commit into from Mar 28, 2017

Conversation

Projects
None yet
2 participants
@gwynjudd
Contributor

gwynjudd commented Mar 24, 2017

I have a number of other localizations available, but I just want to see if I can get everything right with this one as a test before working on the others. It is translated from a localization we did for numeral.js so I want to look out for anything missing there.

@BenjaminVanRyseghem

This comment has been minimized.

Show comment
Hide comment
@BenjaminVanRyseghem

BenjaminVanRyseghem Mar 24, 2017

Owner

why 2 commits with the same short description?

Owner

BenjaminVanRyseghem commented Mar 24, 2017

why 2 commits with the same short description?

@gwynjudd

This comment has been minimized.

Show comment
Hide comment
@gwynjudd

gwynjudd Mar 24, 2017

Contributor

That was my mistake I should have squashed the commits together. I'll have to fix it up on Monday when I get in to work.

When I submit a localisation in not sure what bits are required, is it enough just the languages/xx.js and the tests/languages/xx.js?

Contributor

gwynjudd commented Mar 24, 2017

That was my mistake I should have squashed the commits together. I'll have to fix it up on Monday when I get in to work.

When I submit a localisation in not sure what bits are required, is it enough just the languages/xx.js and the tests/languages/xx.js?

@BenjaminVanRyseghem

This comment has been minimized.

Show comment
Hide comment
@BenjaminVanRyseghem

BenjaminVanRyseghem Mar 24, 2017

Owner

the file + tests should be enough (as we dist for releases)

Now, if you provide a dist, it can potentially be used by people using bleeding-edge 😄

Owner

BenjaminVanRyseghem commented Mar 24, 2017

the file + tests should be enough (as we dist for releases)

Now, if you provide a dist, it can potentially be used by people using bleeding-edge 😄

@gwynjudd

This comment has been minimized.

Show comment
Hide comment
@gwynjudd

gwynjudd Mar 24, 2017

Contributor

Ok I'll keep that in mind for next time

Contributor

gwynjudd commented Mar 24, 2017

Ok I'll keep that in mind for next time

@BenjaminVanRyseghem BenjaminVanRyseghem merged commit 8949079 into BenjaminVanRyseghem:develop Mar 28, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gwynjudd gwynjudd deleted the gwynjudd:de-AT branch Mar 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment