Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add de-AT localization #239

Merged
merged 1 commit into from
Mar 28, 2017

Conversation

gwynjudd
Copy link
Contributor

I have a number of other localizations available, but I just want to see if I can get everything right with this one as a test before working on the others. It is translated from a localization we did for numeral.js so I want to look out for anything missing there.

@BenjaminVanRyseghem
Copy link
Owner

why 2 commits with the same short description?

@gwynjudd
Copy link
Contributor Author

That was my mistake I should have squashed the commits together. I'll have to fix it up on Monday when I get in to work.

When I submit a localisation in not sure what bits are required, is it enough just the languages/xx.js and the tests/languages/xx.js?

@BenjaminVanRyseghem
Copy link
Owner

the file + tests should be enough (as we dist for releases)

Now, if you provide a dist, it can potentially be used by people using bleeding-edge 😄

@gwynjudd
Copy link
Contributor Author

Ok I'll keep that in mind for next time

@BenjaminVanRyseghem BenjaminVanRyseghem merged commit 8949079 into BenjaminVanRyseghem:develop Mar 28, 2017
@gwynjudd gwynjudd deleted the de-AT branch March 28, 2017 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants