Skip to content

Add de-AT localization#239

Merged
BenjaminVanRyseghem merged 1 commit into
BenjaminVanRyseghem:developfrom
gwynjudd:de-AT
Mar 28, 2017
Merged

Add de-AT localization#239
BenjaminVanRyseghem merged 1 commit into
BenjaminVanRyseghem:developfrom
gwynjudd:de-AT

Conversation

@gwynjudd
Copy link
Copy Markdown

I have a number of other localizations available, but I just want to see if I can get everything right with this one as a test before working on the others. It is translated from a localization we did for numeral.js so I want to look out for anything missing there.

@BenjaminVanRyseghem
Copy link
Copy Markdown
Owner

why 2 commits with the same short description?

@gwynjudd
Copy link
Copy Markdown
Author

That was my mistake I should have squashed the commits together. I'll have to fix it up on Monday when I get in to work.

When I submit a localisation in not sure what bits are required, is it enough just the languages/xx.js and the tests/languages/xx.js?

@BenjaminVanRyseghem
Copy link
Copy Markdown
Owner

the file + tests should be enough (as we dist for releases)

Now, if you provide a dist, it can potentially be used by people using bleeding-edge 😄

@gwynjudd
Copy link
Copy Markdown
Author

Ok I'll keep that in mind for next time

@BenjaminVanRyseghem BenjaminVanRyseghem merged commit 8949079 into BenjaminVanRyseghem:develop Mar 28, 2017
@gwynjudd gwynjudd deleted the de-AT branch March 28, 2017 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants