Added bg localization - #241
Merged
Merged
Conversation
Owner
|
your commit is too big (it contains #248). |
Author
|
It is only because this commit requires the other otherwise due to the lint rule I mentioned before it doesn't compile. I'm not at my work right now but it was something like "you have to use '.' notation".
I found this stack overflow post which I think is discussing that rule:
http://stackoverflow.com/questions/13271116/why-does-jslint-prefer-dot-notation-over-square-bracket
If you prefer I can edit the commit so that it doesn't include the other one, but in that case I assume you would have to be aware to merge that one first. I'm not sure what the best thing to do is.
On 27 Mar. 2017 22:20, Benjamin Van Ryseghem <notifications@github.com> wrote:
your commit is too big (it contains #248<https://github.com/foretagsplatsen/numbro/pull/248>).
Can you fix that?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://github.com/foretagsplatsen/numbro/pull/241#issuecomment-289399058>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AATLTD2kZ9T7AZEKC_hsnCtyz1twMPPzks5rp39SgaJpZM4Mpqhf>.
|
gwynjudd
force-pushed
the
bg
branch
2 times, most recently
from
March 27, 2017 21:03
adcf158 to
70c43d5
Compare
Owner
|
Can you remove the "Disable jshint "sub" rule for index.js" commit from this PR? |
Author
|
@BenjaminVanRyseghem done |
Owner
|
in numbro 1.11.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed lint error in generated index.js by using '.' syntax if the localization has no '-'