Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Added bg localization #241
It is only because this commit requires the other otherwise due to the lint rule I mentioned before it doesn't compile. I'm not at my work right now but it was something like "you have to use '.' notation". I found this stack overflow post which I think is discussing that rule: http://stackoverflow.com/questions/13271116/why-does-jslint-prefer-dot-notation-over-square-bracket If you prefer I can edit the commit so that it doesn't include the other one, but in that case I assume you would have to be aware to merge that one first. I'm not sure what the best thing to do is. On 27 Mar. 2017 22:20, Benjamin Van Ryseghem <email@example.com> wrote: your commit is too big (it contains #248<https://github.com/foretagsplatsen/numbro/pull/248>). Can you fix that? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://github.com/foretagsplatsen/numbro/pull/241#issuecomment-289399058>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AATLTD2kZ9T7AZEKC_hsnCtyz1twMPPzks5rp39SgaJpZM4Mpqhf>.
Mar 29, 2017
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passedDetails