New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bg localization #241

Merged
merged 1 commit into from Mar 29, 2017

Conversation

Projects
None yet
2 participants
@gwynjudd
Contributor

gwynjudd commented Mar 27, 2017

Fixed lint error in generated index.js by using '.' syntax if the localization has no '-'

@BenjaminVanRyseghem

This comment has been minimized.

Show comment
Hide comment
@BenjaminVanRyseghem

BenjaminVanRyseghem Mar 27, 2017

Owner

your commit is too big (it contains #248).
Can you fix that?

Owner

BenjaminVanRyseghem commented Mar 27, 2017

your commit is too big (it contains #248).
Can you fix that?

@gwynjudd

This comment has been minimized.

Show comment
Hide comment
@gwynjudd

gwynjudd Mar 27, 2017

Contributor
Contributor

gwynjudd commented Mar 27, 2017

@gwynjudd gwynjudd closed this Mar 27, 2017

@gwynjudd gwynjudd reopened this Mar 27, 2017

@BenjaminVanRyseghem

This comment has been minimized.

Show comment
Hide comment
@BenjaminVanRyseghem

BenjaminVanRyseghem Mar 28, 2017

Owner

Can you remove the "Disable jshint "sub" rule for index.js" commit from this PR?

Owner

BenjaminVanRyseghem commented Mar 28, 2017

Can you remove the "Disable jshint "sub" rule for index.js" commit from this PR?

@gwynjudd

This comment has been minimized.

Show comment
Hide comment
@gwynjudd
Contributor

gwynjudd commented Mar 28, 2017

@BenjaminVanRyseghem BenjaminVanRyseghem merged commit 3e906c1 into BenjaminVanRyseghem:develop Mar 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gwynjudd gwynjudd deleted the gwynjudd:bg branch Mar 29, 2017

@BenjaminVanRyseghem

This comment has been minimized.

Show comment
Hide comment
@BenjaminVanRyseghem

BenjaminVanRyseghem May 2, 2017

Owner

in numbro 1.11.0

Owner

BenjaminVanRyseghem commented May 2, 2017

in numbro 1.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment