Fix index.js generation for culture neutral codes#248
Merged
Conversation
This was referenced Mar 27, 2017
Closed
Merged
Merged
Closed
Owner
|
can you point me the lint rule? because to me you're fix looks a bit strange as both forms are equivalent. |
This was referenced Mar 27, 2017
Merged
Merged
Merged
Author
|
I think it is something like this rule here but I'm not at my work PC to check it
http://stackoverflow.com/questions/13271116/why-does-jslint-prefer-dot-notation-over-square-bracket
|
Owner
|
I would disable the lint rule 😄 |
Author
|
@BenjaminVanRyseghem I've disabled the rule |
BenjaminVanRyseghem
requested changes
Mar 28, 2017
| }).join('\n'); | ||
|
|
||
| fs.writeFileSync(dir + '/index.js', langFiles); | ||
| fs.writeFileSync(dir + '/index.js', '/* jshint sub: true */' + require('os').EOL); |
There was a problem hiding this comment.
can you use \n instead of require('os').EOL to be consistent with the rest of the file?
Without this rule, it will fail at build time if the languages include any language neutral culture codes e.g. "es"
Author
|
@BenjaminVanRyseghem done |
Owner
|
in numbro 1.11.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E.g., for culture code 'nn', it will put
exports.nn = require('./nn.js')j;
into the index.js. Without this change, it fails at build time due to a lint rule