New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix index.js generation for culture neutral codes #248

Merged
merged 1 commit into from Mar 29, 2017

Conversation

Projects
None yet
2 participants
@gwynjudd
Contributor

gwynjudd commented Mar 27, 2017

E.g., for culture code 'nn', it will put

exports.nn = require('./nn.js')j;

into the index.js. Without this change, it fails at build time due to a lint rule

@BenjaminVanRyseghem

This comment has been minimized.

Show comment
Hide comment
@BenjaminVanRyseghem

BenjaminVanRyseghem Mar 27, 2017

Owner

can you point me the lint rule?

because to me you're fix looks a bit strange as both forms are equivalent.
Maybe we should fix the lint rule instead?

Owner

BenjaminVanRyseghem commented Mar 27, 2017

can you point me the lint rule?

because to me you're fix looks a bit strange as both forms are equivalent.
Maybe we should fix the lint rule instead?

This was referenced Mar 27, 2017

@gwynjudd

This comment has been minimized.

Show comment
Hide comment
@gwynjudd

gwynjudd Mar 27, 2017

Contributor
Contributor

gwynjudd commented Mar 27, 2017

@BenjaminVanRyseghem

This comment has been minimized.

Show comment
Hide comment
@BenjaminVanRyseghem

BenjaminVanRyseghem Mar 27, 2017

Owner

I would disable the lint rule 😄

Owner

BenjaminVanRyseghem commented Mar 27, 2017

I would disable the lint rule 😄

@gwynjudd

This comment has been minimized.

Show comment
Hide comment
@gwynjudd

gwynjudd Mar 27, 2017

Contributor

@BenjaminVanRyseghem I've disabled the rule

Contributor

gwynjudd commented Mar 27, 2017

@BenjaminVanRyseghem I've disabled the rule

Show outdated Hide outdated Gruntfile.js Outdated
Disable jshint "sub" rule for index.js
Without this rule, it will fail at build time if the languages include any
language neutral culture codes e.g. "es"
@gwynjudd

This comment has been minimized.

Show comment
Hide comment
@gwynjudd
Contributor

gwynjudd commented Mar 28, 2017

@BenjaminVanRyseghem BenjaminVanRyseghem merged commit 99e9e0f into BenjaminVanRyseghem:develop Mar 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gwynjudd gwynjudd deleted the gwynjudd:index branch Mar 29, 2017

@BenjaminVanRyseghem

This comment has been minimized.

Show comment
Hide comment
@BenjaminVanRyseghem

BenjaminVanRyseghem May 2, 2017

Owner

in numbro 1.11.0

Owner

BenjaminVanRyseghem commented May 2, 2017

in numbro 1.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment