Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added el localization #260

Merged
merged 1 commit into from Mar 29, 2017
Merged

Conversation

@gwynjudd
Copy link
Contributor

@gwynjudd gwynjudd commented Mar 27, 2017

No description provided.

@gwynjudd gwynjudd force-pushed the gwynjudd:el branch from ab9248e to 259c53a Mar 27, 2017
if (prop.indexOf('-') < 0) {
return 'exports.' + prop + ' = require(\'./' + file + '\');';
} else {
return 'exports[\'' + prop + '\'] = require(\'./' + file + '\');';

This comment has been minimized.

@BenjaminVanRyseghem

BenjaminVanRyseghem Mar 27, 2017
Owner

can you explain why?

because to me the only difference I see here is that now it does

exports.el

instead of

exports['el']

while both are equivalent.

Am I missing something?

This comment has been minimized.

@gwynjudd

gwynjudd Mar 27, 2017
Author Contributor

It is because of the jshint rule that forbids it (in jshint, search for "sub"). I have fixed it another way

@gwynjudd gwynjudd force-pushed the gwynjudd:el branch from 259c53a to c56fc7e Mar 27, 2017
@BenjaminVanRyseghem
Copy link
Owner

@BenjaminVanRyseghem BenjaminVanRyseghem commented Mar 28, 2017

can you remove the commit "Disable jshint "sub" rule for index.js" from this PR?

@gwynjudd gwynjudd force-pushed the gwynjudd:el branch from c56fc7e to cc0c579 Mar 28, 2017
@gwynjudd gwynjudd force-pushed the gwynjudd:el branch from cc0c579 to 7802b86 Mar 28, 2017
@gwynjudd
Copy link
Contributor Author

@gwynjudd gwynjudd commented Mar 28, 2017

@BenjaminVanRyseghem it is done, please note without that other commit you may see this build error:

Running "jshint:all" (jshint) task
   languages/index.js
      7 |exports['el'] = require('./el.js');
                ^ ['el'] is better written in dot notation.
>> 1 error in 47 files
Warning: Task "jshint:all" failed. Use --force to continue.
Aborted due to warnings.
@BenjaminVanRyseghem BenjaminVanRyseghem merged commit ef498d0 into BenjaminVanRyseghem:develop Mar 29, 2017
@gwynjudd gwynjudd deleted the gwynjudd:el branch Mar 29, 2017
@BenjaminVanRyseghem
Copy link
Owner

@BenjaminVanRyseghem BenjaminVanRyseghem commented May 2, 2017

in numbro 1.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.