Added el localization#260
Merged
BenjaminVanRyseghem merged 1 commit intoBenjaminVanRyseghem:developfrom Mar 29, 2017
Merged
Conversation
| if (prop.indexOf('-') < 0) { | ||
| return 'exports.' + prop + ' = require(\'./' + file + '\');'; | ||
| } else { | ||
| return 'exports[\'' + prop + '\'] = require(\'./' + file + '\');'; |
There was a problem hiding this comment.
can you explain why?
because to me the only difference I see here is that now it does
exports.el
instead of
exports['el']
while both are equivalent.
Am I missing something?
Author
There was a problem hiding this comment.
It is because of the jshint rule that forbids it (in jshint, search for "sub"). I have fixed it another way
Owner
|
can you remove the commit "Disable jshint "sub" rule for index.js" from this PR? |
Author
|
@BenjaminVanRyseghem it is done, please note without that other commit you may see this build error: |
Owner
|
in numbro 1.11.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.