New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added el localization #260

Merged
merged 1 commit into from Mar 29, 2017

Conversation

Projects
None yet
2 participants
@gwynjudd
Contributor

gwynjudd commented Mar 27, 2017

No description provided.

Show outdated Hide outdated Gruntfile.js Outdated
@BenjaminVanRyseghem

This comment has been minimized.

Show comment
Hide comment
@BenjaminVanRyseghem

BenjaminVanRyseghem Mar 28, 2017

Owner

can you remove the commit "Disable jshint "sub" rule for index.js" from this PR?

Owner

BenjaminVanRyseghem commented Mar 28, 2017

can you remove the commit "Disable jshint "sub" rule for index.js" from this PR?

@gwynjudd

This comment has been minimized.

Show comment
Hide comment
@gwynjudd

gwynjudd Mar 28, 2017

Contributor

@BenjaminVanRyseghem it is done, please note without that other commit you may see this build error:

Running "jshint:all" (jshint) task
   languages/index.js
      7 |exports['el'] = require('./el.js');
                ^ ['el'] is better written in dot notation.
>> 1 error in 47 files
Warning: Task "jshint:all" failed. Use --force to continue.
Aborted due to warnings.
Contributor

gwynjudd commented Mar 28, 2017

@BenjaminVanRyseghem it is done, please note without that other commit you may see this build error:

Running "jshint:all" (jshint) task
   languages/index.js
      7 |exports['el'] = require('./el.js');
                ^ ['el'] is better written in dot notation.
>> 1 error in 47 files
Warning: Task "jshint:all" failed. Use --force to continue.
Aborted due to warnings.

@BenjaminVanRyseghem BenjaminVanRyseghem merged commit ef498d0 into BenjaminVanRyseghem:develop Mar 29, 2017

@gwynjudd gwynjudd deleted the gwynjudd:el branch Mar 29, 2017

@BenjaminVanRyseghem

This comment has been minimized.

Show comment
Hide comment
@BenjaminVanRyseghem

BenjaminVanRyseghem May 2, 2017

Owner

in numbro 1.11.0

Owner

BenjaminVanRyseghem commented May 2, 2017

in numbro 1.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment