fix typing of numbro.languages()#342
Merged
BenjaminVanRyseghem merged 2 commits intoMar 20, 2018
Merged
Conversation
Owner
|
Thanks 👍 |
Owner
|
can you add yourself in the AUTHORS file please 😄 ? |
Contributor
Author
|
Thanks, I don't think I deserve that yet ;) Will do that later when I have a more significant contribution. |
Owner
|
you do deserve it! There is no such thing as a "too small fix" 😄 (plus, if you don't I will 😛 ) |
Contributor
Author
|
Here it is then -- thanks :) |
Owner
|
Thanks to you 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
numbro.languages()is typed incorrectly in the TypeScript typings; in Numbro 2.x,languages()returns an object that maps language tags to the correspondingNumbroLanguageobjects, but the typing claims that the function returns an array ofNumbroLanguageobjects. This pull request fixes the issue.