New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typing of numbro.languages() #342

Merged
merged 2 commits into from Mar 20, 2018

Conversation

Projects
None yet
2 participants
@ntamas
Contributor

ntamas commented Mar 20, 2018

numbro.languages() is typed incorrectly in the TypeScript typings; in Numbro 2.x, languages() returns an object that maps language tags to the corresponding NumbroLanguage objects, but the typing claims that the function returns an array of NumbroLanguage objects. This pull request fixes the issue.

@BenjaminVanRyseghem

This comment has been minimized.

Owner

BenjaminVanRyseghem commented Mar 20, 2018

Thanks 👍

@BenjaminVanRyseghem

This comment has been minimized.

Owner

BenjaminVanRyseghem commented Mar 20, 2018

can you add yourself in the AUTHORS file please 😄 ?

@ntamas

This comment has been minimized.

Contributor

ntamas commented Mar 20, 2018

Thanks, I don't think I deserve that yet ;) Will do that later when I have a more significant contribution.

@BenjaminVanRyseghem

This comment has been minimized.

Owner

BenjaminVanRyseghem commented Mar 20, 2018

you do deserve it! There is no such thing as a "too small fix" 😄

(plus, if you don't I will 😛 )

@ntamas

This comment has been minimized.

Contributor

ntamas commented Mar 20, 2018

Here it is then -- thanks :)

@BenjaminVanRyseghem BenjaminVanRyseghem merged commit f008331 into BenjaminVanRyseghem:develop Mar 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@BenjaminVanRyseghem

This comment has been minimized.

Owner

BenjaminVanRyseghem commented Mar 20, 2018

Thanks to you 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment