Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export Format interface #345

Merged
merged 1 commit into from Mar 30, 2018
Merged

export Format interface #345

merged 1 commit into from Mar 30, 2018

Conversation

@jordydejong
Copy link
Contributor

@jordydejong jordydejong commented Mar 30, 2018

I've added an export to the Format interface, I would like to be able to import and use it in my code

@BenjaminVanRyseghem
Copy link
Owner

@BenjaminVanRyseghem BenjaminVanRyseghem commented Mar 30, 2018

sure 😄

Just out of curiosity, could you tell me a bit about your project? 😄

@BenjaminVanRyseghem BenjaminVanRyseghem merged commit ba51102 into BenjaminVanRyseghem:develop Mar 30, 2018
1 check passed
@jordydejong
Copy link
Contributor Author

@jordydejong jordydejong commented Mar 30, 2018

I'm creating a wrapper component around numbro, which reads the locale from a react-18next instance

something like

numbro.setLanguage(this.props.i18n.language)
return <span>{numbro(this.props.value).format(this.props.format)}</span>

@BenjaminVanRyseghem
Copy link
Owner

@BenjaminVanRyseghem BenjaminVanRyseghem commented Jun 13, 2018

in numbro 2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants