Enable es6 imports when using typescript#363
Merged
BenjaminVanRyseghem merged 2 commits intoBenjaminVanRyseghem:developfrom Jul 23, 2018
Merged
Enable es6 imports when using typescript#363BenjaminVanRyseghem merged 2 commits intoBenjaminVanRyseghem:developfrom
BenjaminVanRyseghem merged 2 commits intoBenjaminVanRyseghem:developfrom
Conversation
Owner
|
Thanks for your contribution 😄 could you add yourself in the AUTHORS file please 😄 ? I'll merge this PR right after that |
Contributor
Author
|
@BenjaminVanRyseghem Is ths PR ok to merge now? |
Owner
|
Thanks for your contribution 😄 |
Owner
|
in v2.1.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
.d.tsfile, numbro is being exported usingexport = numbro. In the PR that made this change, it says this is the only way to use it in typescript #232 , and it proposes to useto import. However, in newer versions, this now causes default to be imported as a
.defaultmember instead. Now, the only way of importing numbro properly isThis change enables using es6 syntax to import
#352 explains the change in further detail.