Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes duplicate call of chooseLanguage when setting a language without subtag #367

Merged
merged 2 commits into from Jul 13, 2018

Conversation

@LarsBauer
Copy link
Contributor

@LarsBauer LarsBauer commented Jul 13, 2018

Fixes a duplicate call of chooseLanguage when setting a language without subtag (e.g. "en"). To prevent the assignment of currentLanguageTag with non matching tag I added a missing return statement in the setLanguage method of numbro.

@BenjaminVanRyseghem
Copy link
Owner

@BenjaminVanRyseghem BenjaminVanRyseghem commented Jul 13, 2018

good catch!!

Could you add a test covering this case? That would prevent having the same issue later on 😄

Also, please add yourself to the AUTHORS file 😄

@LarsBauer
Copy link
Contributor Author

@LarsBauer LarsBauer commented Jul 13, 2018

Thank you for your quick response! 😄

I added the missing test case. Eager to fix this issue I totally forgot to read your contributor guideline. Shame on me...

@BenjaminVanRyseghem BenjaminVanRyseghem merged commit 675b697 into BenjaminVanRyseghem:develop Jul 13, 2018
1 check passed
@BenjaminVanRyseghem
Copy link
Owner

@BenjaminVanRyseghem BenjaminVanRyseghem commented Jul 13, 2018

No problem 😄

@BenjaminVanRyseghem
Copy link
Owner

@BenjaminVanRyseghem BenjaminVanRyseghem commented Oct 17, 2018

in v2.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants