Fixes duplicate call of chooseLanguage when setting a language without subtag #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
good catch!! Could you add a test covering this case? That would prevent having the same issue later on 😄 Also, please add yourself to the AUTHORS file 😄 |
Contributor
Author
|
Thank you for your quick response! 😄 I added the missing test case. Eager to fix this issue I totally forgot to read your contributor guideline. Shame on me... |
Owner
|
No problem 😄 |
Owner
|
in v2.1.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a duplicate call of
chooseLanguagewhen setting a language without subtag (e.g. "en"). To prevent the assignment ofcurrentLanguageTagwith non matching tag I added a missing return statement in thesetLanguagemethod of numbro.