Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #399

Conversation

@baer
Copy link
Contributor

@baer baer commented Dec 13, 2018

Problem

Out of date dependencies were causing the following issues:

  • Unable to npm install on Node 10
  • Deprecated es2015 babel preset is no longer getting fixes for compat
  • Npm reports 421 vulnerabilities (386 low, 18 moderate, 15 high, 2 critical) in the project

Fix

  • Update dependencies
  • Add npm run lint to the package.json - it was missing
  • Add missing jasmine and istanbul dependencies to make npm run coverage work properly
@@ -0,0 +1,3 @@
module.exports = {
presets: ["@babel/preset-env"]
Copy link
Contributor Author

@baer baer Dec 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be transparent. Babel's docs specify that:

"By default, it has the same behavior as previous presets to compile ES2015+ to ES5"
https://babeljs.io/docs/en/env

The great thing about this plugin (if you haven't used it yet) is that you can add config to specify a support matrix and only the applicable presets will be applied. For example, if you only want to support down to IE9 and Node LTS you could easily do that.

"gulp-util": "^3.0.8",
"istanbul": "^0.4.5",
"jasmine": "^3.3.1",
Copy link
Contributor Author

@baer baer Dec 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two were included as transitive deps but without a top level include they are not available in the node_modules/.bin directory which means that the npm run coverage script wasn't working.

@BenjaminVanRyseghem BenjaminVanRyseghem self-requested a review Dec 14, 2018
@BenjaminVanRyseghem BenjaminVanRyseghem merged commit 98c4609 into BenjaminVanRyseghem:develop Dec 14, 2018
1 check passed
@BenjaminVanRyseghem
Copy link
Owner

@BenjaminVanRyseghem BenjaminVanRyseghem commented Dec 14, 2018

Thank you 😄

@BenjaminVanRyseghem
Copy link
Owner

@BenjaminVanRyseghem BenjaminVanRyseghem commented Jan 18, 2019

in numbro 2.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants