Update dependencies#399
Merged
BenjaminVanRyseghem merged 4 commits intoBenjaminVanRyseghem:developfrom Dec 14, 2018
baer:feature/update-dependencies
Merged
Update dependencies#399BenjaminVanRyseghem merged 4 commits intoBenjaminVanRyseghem:developfrom baer:feature/update-dependencies
BenjaminVanRyseghem merged 4 commits intoBenjaminVanRyseghem:developfrom
baer:feature/update-dependencies
Conversation
baer
commented
Dec 13, 2018
| @@ -0,0 +1,3 @@ | |||
| module.exports = { | |||
| presets: ["@babel/preset-env"] | |||
Contributor
Author
There was a problem hiding this comment.
This change should be transparent. Babel's docs specify that:
"By default, it has the same behavior as previous presets to compile ES2015+ to ES5"
https://babeljs.io/docs/en/env
The great thing about this plugin (if you haven't used it yet) is that you can add config to specify a support matrix and only the applicable presets will be applied. For example, if you only want to support down to IE9 and Node LTS you could easily do that.
| "gulp-uglify": "^3.0.1", | ||
| "gulp-util": "^3.0.8", | ||
| "istanbul": "^0.4.5", | ||
| "jasmine": "^3.3.1", |
Contributor
Author
There was a problem hiding this comment.
These two were included as transitive deps but without a top level include they are not available in the node_modules/.bin directory which means that the npm run coverage script wasn't working.
Owner
|
Thank you 😄 |
Owner
|
in numbro 2.1.2 |
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Out of date dependencies were causing the following issues:
npm installon Node 10es2015babel preset is no longer getting fixes for compatFix
npm run lintto thepackage.json- it was missingjasmineandistanbuldependencies to makenpm run coveragework properly