Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update delimiters for id language #428

Merged
merged 1 commit into from Oct 11, 2019
Merged

update delimiters for id language #428

merged 1 commit into from Oct 11, 2019

Conversation

kukuhyoniatmoko
Copy link
Contributor

@kukuhyoniatmoko kukuhyoniatmoko commented Jul 22, 2019

I'm indonesian, and here we use '.' as thousands delimiters and decimal delimiters is ','.
Maybe we can use this as reference

@BenjaminVanRyseghem
Copy link
Owner

@BenjaminVanRyseghem BenjaminVanRyseghem commented Oct 11, 2019

Hi :)

Thanks for the PR 😄

Could you please add a line in the CHANGELOG as well as add yourself in the AUTHORS file?

Thanks in advance

@BenjaminVanRyseghem BenjaminVanRyseghem merged commit 014d56c into BenjaminVanRyseghem:develop Oct 11, 2019
1 check passed
kukuhyoniatmoko added a commit to kukuhyoniatmoko/numbro that referenced this issue Nov 19, 2019
kukuhyoniatmoko added a commit to kukuhyoniatmoko/numbro that referenced this issue Nov 19, 2019
BenjaminVanRyseghem pushed a commit that referenced this issue Dec 13, 2019
BenjaminVanRyseghem pushed a commit that referenced this issue Dec 13, 2019
@BenjaminVanRyseghem
Copy link
Owner

@BenjaminVanRyseghem BenjaminVanRyseghem commented Mar 18, 2020

in numbro 2.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants