Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signs fails with dev scales #2

Closed
hadley opened this issue Nov 5, 2019 · 1 comment
Closed

Signs fails with dev scales #2

hadley opened this issue Nov 5, 2019 · 1 comment

Comments

@hadley
Copy link

hadley commented Nov 5, 2019

With many errors like:

signs_format()(x) not equal to c("−1", "0", "1").
3/3 mismatches
x[1]: "−1.0"
y[1]: "−1"

x[2]: "0.0"
y[2]: "0"

x[3]: "1.0"
y[3]: "1"

I think this is because I have adjusted the default accuracy to have a better default across a wider range of inputs. You should be able to return to the previous algorithm by explicitly setting accuracy = 1

@BenjaminWolfe BenjaminWolfe mentioned this issue Nov 25, 2019
16 tasks
@BenjaminWolfe
Copy link
Owner

Fixed in signs 0.1.1! Thanks @hadley!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants