Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upMove default comments to external sources #6
Comments
alerque
added
the
enhancement
label
Mar 1, 2014
alerque
closed this
Mar 1, 2014
alerque
reopened this
Mar 1, 2014
This comment has been minimized.
This comment has been minimized.
I'd leave some site-wide (generic) messages within the script just in case for
|
This comment has been minimized.
This comment has been minimized.
Not a bad idea. That could be in lieu of my fallback URL above. I would still want to see the prompt on first run (per site) to "import site comments" with a pre-filled out URL and "load generic data" (and optionally edit in a textarea) as the secondary method to populate localStorage to encourage use of per-site data sets. If that is silently loaded on all sites by default the awareness that per-site data is even available goes way down. |
This comment has been minimized.
This comment has been minimized.
Agreed. Was not intended as "replacement", just as, say, additional fall-back. So when pulled from the "new sources", would that a) merge with existing entries (I doubt that's easily implemented), b) add to them (would cause dupes), or c) replace (user would lose his own customizations)? As a) most likely won't be the case, user needs an option to decide whether to (always) blindly replace ("trust the source"), or do a manual merge. That's most likely what your last item with "edit/paste" is referring to. With large sets (local and remote), that might get a little tricky. |
added a commit
to alerque/SE-AutoReviewComments
that referenced
this issue
Mar 10, 2014
added a commit
to alerque/SE-AutoReviewComments
that referenced
this issue
Mar 10, 2014
added a commit
to alerque/SE-AutoReviewComments
that referenced
this issue
Mar 10, 2014
This comment has been minimized.
This comment has been minimized.
Some questions with request to this feature:
|
This comment has been minimized.
This comment has been minimized.
@Benjol In order:
|
This comment has been minimized.
This comment has been minimized.
I like @alerque approach with the hostname being part of the URL. That seems pretty flexible. Maybe the user should be allowed to set an alternative base URL. Then the user could just override the files he wants in their own repo. And if no appropriate document is found at the user-specified location, fall back to the default repository. |
This comment has been minimized.
This comment has been minimized.
Further thought: I think if the user customises any comments, the auto-update should be automatically switched off (perhaps with a warning). As it stands, the auto-update fills the localStorage, which suits us if we only want to check once per day. |
This comment has been minimized.
This comment has been minimized.
I'm down with that @Benjol. Having an alternate base_url seems like more trouble than it's worth @oliversalzburg. We don't have a persistent way to set that across sites anyway, and the most likely use case is that the user is interested in a site they have customized, in with case having them enter the remote URL for each site seems reasonable and they can always fork this or compile their own version with a different base URL if our comment sets aren't satisfactorily maintained. I don't know of a way to have a user-entered base-url persist across sites anyway. |
This comment has been minimized.
This comment has been minimized.
Fair enough. I don't really have an understanding of that part of the script anyway :) |
alerque commentedMar 1, 2014
After reading the chatter the other day about comment data and import/export, I've been thinking our arrangement could be something like this:
How does that arrangement scan?