Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing config implementations #738

Closed
2 tasks done
BONNe opened this issue Jun 6, 2019 · 2 comments
Closed
2 tasks done

Missing config implementations #738

BONNe opened this issue Jun 6, 2019 · 2 comments
Assignees
@BONNe
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug
Milestone
1.5.0

Comments

@BONNe
Copy link
Member

BONNe commented Jun 6, 2019 •
edited by tastybento
Loading

Description

Describe the bug

In issue #727 we found out that some config options are not implemented at all.
I create this bug report with all missing implementations.

Missing Implementations

  • leavers-lose-reset
  • kicked-keep-inventory
  • sum-team - sum team death count
@BONNe BONNe added Status: Pending Waiting for a developer to start working on this issue. Type: Bug labels Jun 6, 2019
@Poslovitch Poslovitch mentioned this issue Jun 7, 2019
Closed
@tastybento tastybento self-assigned this Jun 8, 2019
@tastybento tastybento added Status: In progress Working on the issue. and removed Status: Pending Waiting for a developer to start working on this issue. labels Jun 8, 2019
tastybento added a commit that referenced this issue Jun 8, 2019
@tastybento
Added sum deaths setting support.
f0baeec 
Other items WIP
#738
tastybento added a commit that referenced this issue Jun 8, 2019
@tastybento
Removes a reset from player if they leave an island
ccdfccd 
#738
tastybento added a commit that referenced this issue Jun 8, 2019
@tastybento
Implements kicked-keep-inventory config setting.
efdb9a2 
#738
tastybento added a commit to BentoBoxWorld/BSkyBlock that referenced this issue Jun 8, 2019
@tastybento
Cleans up kicked-keep-inventory config setting.
b2aa604 
BentoBoxWorld/BentoBox#738
tastybento added a commit to BentoBoxWorld/AcidIsland that referenced this issue Jun 8, 2019
@tastybento
Cleans up kicked-keep-inventory config setting.
f230715 
BentoBoxWorld/BentoBox#738
@tastybento tastybento added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: In progress Working on the issue. labels Jun 8, 2019
@tastybento tastybento added this to the 1.5.0 milestone Jun 8, 2019
@tastybento
Copy link
Member

@BONNe These should be done. Please check and close.

@tastybento tastybento assigned BONNe and unassigned tastybento Jun 8, 2019
@tastybento
Copy link
Member

By the way, after hearing from @Poslovitch and thinking about it, I've removed sum-team deaths from WorldSettings. It's a left-over from the level calculator in ASkyBlock. I'll add it is a setting for level.

tastybento added a commit to BentoBoxWorld/BSkyBlock that referenced this issue Jun 10, 2019
@tastybento
Cleans up kicked-keep-inventory config setting.
8dd968a 
BentoBoxWorld/BentoBox#738
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BONNe BONNe

Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
3 participants
@BONNe @tastybento @Poslovitch