Lag spikes due to timer task that triggers every 6000 ticks

[MorkaZ]

BentoBox::Task: world.bentobox.bentobox.BentoBox$$Lambda$2942/1667770658 (interval:6000)
This thing generates big lag spikes everytime it triggers. Can you please optimalize it?
I think it is timed task that saves islands evey X time.
Using latest paper spigot 1.13 with bungeecord on Java 8.
If any other information will be needed then please post below.

[tastybento]

This is the full database save. You can change how often it occurs in the BentoBox config.

[MorkaZ]

Thanks for reply but I think it should be done asynchronously if it has not links with main thread to not affect performance or at least it should be done in parts to not freeze server for seconds if database is bigger.
Anyway I think that optimalization is necessary.

[tastybento]

What database are you using? Database saves are async. Do you actually see the server freeze for seconds or is this just from the timings report?

[MorkaZ]

When it was every 5 minutes it was very annoying for players.
I am using MariaDB (Debian mysql default). I have 120~ players online (50 - 180) on this server and it was started 5 months ago.

I think simplest way to solve this problem is to split this database backup process to parts, for example schedule next part every 2000 rows (modulo 2000) and add 20 ticks to every next timed task to make this spikes be very small or just run it asynchronously because all sql databases do not require to be synchronous with main thread.

[tastybento]

Thanks. I'll work on improving this. SQL saving is async, but there can be improvements so the prep tasks can be written better.

[tastybento]

SHould be optimized now. Comments appreciated.