From 0b4f5fe19bb0182eefe97db371ae681575f35e87 Mon Sep 17 00:00:00 2001 From: tastybento Date: Thu, 9 Feb 2023 22:55:59 -0800 Subject: [PATCH] Minor refactor to reduce complexity. --- .../com/wasteofplastic/invswitcher/Store.java | 112 +++++++++--------- 1 file changed, 57 insertions(+), 55 deletions(-) diff --git a/src/main/java/com/wasteofplastic/invswitcher/Store.java b/src/main/java/com/wasteofplastic/invswitcher/Store.java index 630439d..9502ae0 100644 --- a/src/main/java/com/wasteofplastic/invswitcher/Store.java +++ b/src/main/java/com/wasteofplastic/invswitcher/Store.java @@ -306,40 +306,42 @@ private void saveStats(InventoryStorage store, Player player, String worldName) */ private void getStats(InventoryStorage store, Player player, String worldName) { // Statistics - Arrays.stream(Statistic.values()).forEach(s -> { - switch(s.getType()) { - case BLOCK: - if (store.getBlockStats(worldName).containsKey(s)) { - for (Entry en : store.getBlockStats(worldName).get(s).entrySet()) { - player.setStatistic(s, en.getKey(), en.getValue()); - } - } - break; - case ITEM: - if (store.getItemStats(worldName).containsKey(s)) { - for (Entry en : store.getItemStats(worldName).get(s).entrySet()) { - player.setStatistic(s, en.getKey(), en.getValue()); - } + Arrays.stream(Statistic.values()).forEach(s -> getStat(s, store, player, worldName)); + + } + + private void getStat(Statistic s, InventoryStorage store, Player player, String worldName) { + switch(s.getType()) { + case BLOCK: + if (store.getBlockStats(worldName).containsKey(s)) { + for (Entry en : store.getBlockStats(worldName).get(s).entrySet()) { + player.setStatistic(s, en.getKey(), en.getValue()); } - break; - case ENTITY: - if (store.getEntityStats(worldName).containsKey(s)) { - for (Entry en : store.getEntityStats(worldName).get(s).entrySet()) { - player.setStatistic(s, en.getKey(), en.getValue()); - } + } + break; + case ITEM: + if (store.getItemStats(worldName).containsKey(s)) { + for (Entry en : store.getItemStats(worldName).get(s).entrySet()) { + player.setStatistic(s, en.getKey(), en.getValue()); } - break; - case UNTYPED: - if (store.getUntypedStats(worldName).containsKey(s)) { - player.setStatistic(s, store.getUntypedStats(worldName).get(s)); + } + break; + case ENTITY: + if (store.getEntityStats(worldName).containsKey(s)) { + for (Entry en : store.getEntityStats(worldName).get(s).entrySet()) { + player.setStatistic(s, en.getKey(), en.getValue()); } - break; - default: - break; - } - }); + break; + case UNTYPED: + if (store.getUntypedStats(worldName).containsKey(s)) { + player.setStatistic(s, store.getUntypedStats(worldName).get(s)); + } + break; + default: + break; + } } @SuppressWarnings("deprecation") @@ -381,38 +383,38 @@ private void clearPlayer(Player player) { { switch (s.getType()) { - case BLOCK: - for (Material m : Material.values()) + case BLOCK: + for (Material m : Material.values()) + { + if (m.isBlock() && !m.isLegacy()) { - if (m.isBlock() && !m.isLegacy()) - { - player.setStatistic(s, m, 0); - } + player.setStatistic(s, m, 0); } - break; - case ITEM: - for (Material m : Material.values()) + } + break; + case ITEM: + for (Material m : Material.values()) + { + if (m.isItem() && !m.isLegacy()) { - if (m.isItem() && !m.isLegacy()) - { - player.setStatistic(s, m, 0); - } + player.setStatistic(s, m, 0); } - break; - case ENTITY: - for (EntityType en : EntityType.values()) + } + break; + case ENTITY: + for (EntityType en : EntityType.values()) + { + if (en.isAlive()) { - if (en.isAlive()) - { - player.setStatistic(s, en, 0); - } + player.setStatistic(s, en, 0); } - break; - case UNTYPED: - player.setStatistic(s, 0); - break; - default: - break; + } + break; + case UNTYPED: + player.setStatistic(s, 0); + break; + default: + break; } }); }