Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Critical] farm block bug , need hot fix , please #44

Closed
p82183645 opened this issue Sep 8, 2019 · 2 comments
Closed

[Critical] farm block bug , need hot fix , please #44

p82183645 opened this issue Sep 8, 2019 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@p82183645
Copy link

p82183645 commented Sep 8, 2019

if set
WHEAT: 10 , the can't limits 10 When you plant x10 and then dismantle it, he will think you have 10
Then you never fram again

Please add limits on crops fram
only happen the all about fram block

WHEAT
SUGAR_CANE
BAMBOO
CARROT
POTATO
SWEET_BERRIES
NETHER_WART
ALL

@tastybento tastybento self-assigned this Sep 8, 2019
@tastybento tastybento added bug Something isn't working under investigation this is being looked into labels Sep 8, 2019
@tastybento
Copy link
Member

tastybento commented Sep 8, 2019

I never designed Limits to limit crops. Limits was originally designed for limiting blocks that cause lag. Anyway, I'll see what I can do. I cannot promise a quick or "hot fix".

Here are my findings so far:

  • Sugar cane
    Canes can be placed on top of each other, but when broken at the bottom, the full height is broken but not recognized. This is a bug.

  • Wheat
    WHEAT_SEEDS are planted but yield the block of type WHEAT. But if a WHEAT block is broken before it is fully grown, it yields WHEAT_SEEDS, not WHEAT. This will need special handling.

  • Bamboo
    For bamboo, initial blocks are BAMBOO_SAPLING not BAMBOO and breaking has same problem as SUGAR_CANE. Limit should be placed in config on BAMBOO.

  • Carrots and potatoes
    Use CARROTS and POTATOES instead of CARROT and POTATO. Currently, they do not show in the GUI. This is a bug and I'll fix it.

  • Sweet berries
    Similar to carrots, SWEET_BERRIES must be SWEET_BERRY_BUSH in the limits config. This also does not show in the GUI yet.

  • Netherwart
    Seems to work okay. I'm testing still because they cannot be grown quickly.

  • Others
    It's likely that other crops need addressing, like beetroot. They'll need to be checked out.

@tastybento tastybento added in progress being worked on and removed in progress being worked on under investigation this is being looked into labels Sep 9, 2019
@tastybento
Copy link
Member

Okay, I've fixed these issues. There is a fundamental problem though and that is players can break blocks under crops and the broken crops cannot be caught. Well, they can, but using a lot of code. For now, I've added a user command "recount" that players can use (cool down = 2 minutes) to check if the count is okay. Disable with perms if you like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants