Prioritize the shallowest path for the same assembly name in the default providers (#980)

Change the behaviors of the default providers so if multiple assemblies with the same name exists, but in different directories, ignore any that are located deeper.

Author: aldelaro5

BepInEx.PatcherProvider/BepInExPatcherProvider.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Collections.Generic;
 using System.IO;
+using System.Linq;
 using System.Reflection;
 using BepInEx.Logging;
 using BepInEx.Preloader.Core.Patching;
@@ -19,7 +20,28 @@ public override IList<IPluginLoadContext> GetPatchers()
         {
             try
             {
-                AssemblyLocationsByFilename.Add(Path.GetFileNameWithoutExtension(dll), Path.GetDirectoryName(dll));
+                var filename = Path.GetFileNameWithoutExtension(dll);
+                var foundDirectory = Path.GetDirectoryName(dll);
+                
+                // Prioritize the shallowest path of each assembly name
+                if (AssemblyLocationsByFilename.TryGetValue(filename, out var existingDirectory))
+                {
+                    int levelExistingDirectory = existingDirectory?.Count(x => x == Path.DirectorySeparatorChar) ?? 0;
+                    int levelFoundDirectory = foundDirectory?.Count(x => x == Path.DirectorySeparatorChar) ?? 0;
+                    
+                    bool shallowerPathFound = levelExistingDirectory > levelFoundDirectory;
+                    Log.LogWarning($"Found duplicate assemblies filenames: {filename} was found at {foundDirectory} " +
+                                   $"while it exists already at {AssemblyLocationsByFilename[filename]}. " +
+                                   $"Only the {(shallowerPathFound ? "first" : "second")} will be examined and resolved");
+                    
+                    if (levelExistingDirectory > levelFoundDirectory)
+                        AssemblyLocationsByFilename[filename] = foundDirectory;
+                }
+                else
+                {
+                    AssemblyLocationsByFilename.Add(filename, foundDirectory);
+                }
+                
                 loadContexts.Add(new BepInExPatcherLoadContext
                 {
                     AssemblyHash = File.GetLastWriteTimeUtc(dll).ToString("O"),

BepInEx.PluginProvider/BepInExPluginProvider.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Collections.Generic;
 using System.IO;
+using System.Linq;
 using System.Reflection;
 using BepInEx.Logging;
 
@@ -18,7 +19,28 @@ public override IList<IPluginLoadContext> GetPlugins()
         {
             try
             {
-                AssemblyLocationsByFilename.Add(Path.GetFileNameWithoutExtension(dll), Path.GetDirectoryName(dll));
+                var filename = Path.GetFileNameWithoutExtension(dll);
+                var foundDirectory = Path.GetDirectoryName(dll);
+                
+                // Prioritize the shallowest path of each assembly name
+                if (AssemblyLocationsByFilename.TryGetValue(filename, out var existingDirectory))
+                {
+                    int levelExistingDirectory = existingDirectory?.Count(x => x == Path.DirectorySeparatorChar) ?? 0;
+                    int levelFoundDirectory = foundDirectory?.Count(x => x == Path.DirectorySeparatorChar) ?? 0;
+
+                    bool shallowerPathFound = levelExistingDirectory > levelFoundDirectory;
+                    Logger.LogWarning($"Found duplicate assemblies filenames: {filename} was found at {foundDirectory} " +
+                                      $"while it exists already at {AssemblyLocationsByFilename[filename]}. " +
+                                      $"Only the {(shallowerPathFound ? "first" : "second")} will be examined and resolved");
+                    
+                    if (levelExistingDirectory > levelFoundDirectory)
+                        AssemblyLocationsByFilename[filename] = foundDirectory;
+                }
+                else
+                {
+                    AssemblyLocationsByFilename.Add(filename, foundDirectory);
+                }
+
                 loadContexts.Add(new BepInExPluginLoadContext
                 {
                     AssemblyHash = File.GetLastWriteTimeUtc(dll).ToString("O"),