Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.4.1 does not upgrade assemblies loaded via Assembly.LoadFrom #158

Closed
ghorsington opened this issue Nov 21, 2020 · 3 comments
Closed

5.4.1 does not upgrade assemblies loaded via Assembly.LoadFrom #158

ghorsington opened this issue Nov 21, 2020 · 3 comments

Comments

@ghorsington
Copy link
Contributor

Describe the bug

BepInEx 5.4.1 fails to automatically upgrade 5.3 assemblies in case they are loaded via Assembly.LoadFrom

To Reproduce

  1. Compile an old DLL that uses old Harmony
  2. Try to load said DLL via Assembly.LoadFrom and invoke its Harmony patches

Expected behavior

DLL is automatically upgraded to work with BepInEx 5.4.1 and patches are applied.

Screenshots and logs

Check latest comments in #147 for error logs.

Desktop (please complete the following information):

  • BepInEx version [e.g. 4.0]: 5.4.1
@ghorsington
Copy link
Contributor Author

@gbooker Do you mind testing the following version:

BepInEx_unix_5.4.2.0.zip

This should likely fix the problem with loading of some assemblies that you reported in #147.

Please include the logs like before.

@ghorsington
Copy link
Contributor Author

This was tested and seems to be fixed, closing the issue

@gbooker
Copy link

gbooker commented Nov 23, 2020

I know I'm late to this but I did get around to testing this just now and it works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants