Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exploit additional concurrency in the training algorithm #105

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Conversation

rouson
Copy link
Contributor

@rouson rouson commented Dec 20, 2023

This PR switches two do loops in the training algorithm to do concurrent constructs. Inspection of the code indicates that there are no values defined in one iteration that are accessed in a subsequent iteration. This conclusion was also tested by temporarily changing the stride of each affected do loops from the default (1) to -1 in order to reverse the order of the iterations. With a stride of -1, all tests pass and app/train-cloud-microphysics.f90 yields the same convergence behavior as with a stride of 1 when run as follows using a training data set from ICAR.

./build/run-fpm.sh run -- --base training --start 720 --epochs 40 

Copy link
Contributor

@everythingfunctional everythingfunctional left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rouson rouson removed the request for review from ktras December 20, 2023 23:25
@rouson rouson merged commit 55bbbcb into main Dec 20, 2023
4 checks passed
@rouson rouson deleted the concurrency branch December 20, 2023 23:25
@rouson
Copy link
Contributor Author

rouson commented Dec 20, 2023

Thanks for the review, @everythingfunctional !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants