Fix timeout bug for SageMaker Messages API completion#8635
Merged
3 commits merged intoFeb 18, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ghost
changed the base branch from
ghost
pushed a commit
that referenced
this pull request
Feb 18, 2025
* fix(filter.tsx): align filter icon to button correctly * style: style improvements for filter icon * style(filter.tsx): cleanup filter box * style(filter.tsx): style improvement for team id box on filter * Fix timeout bug for SageMaker Messages API completion (#8635) * fix(model_cost_map): fix json parse error on model cost map + add unit test (#8629) Fixes #8619 (comment) * Fix timeout bug for SageMaker Messages API completion --------- Co-authored-by: Krish Dholakia <krrishdholakia@gmail.com> --------- Co-authored-by: Bobby Lindsey <bobbywlindsey@users.noreply.github.com>
ghost
mentioned this pull request
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
The
timeoutparameter is not being successfully passed to thecompletionfunction inllms/sagemaker/chat/handler.pycausing completion timeouts.Relevant issues
Fixes #8373
Type
🐛 Bug Fix
Changes
Added
timeoutparameter to thesagemaker_chat_completion.completionfunction call inmain.py.