Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt for resolve issue #2 #3

Merged
merged 8 commits into from Aug 8, 2021
Merged

Conversation

wenjie2wang
Copy link
Contributor

See issue #2 for details.

@BerriJ BerriJ changed the base branch from main to develop August 8, 2021 19:27
@BerriJ
Copy link
Owner

BerriJ commented Aug 8, 2021

Thank you very much for this PR.

FYI I merged commits from the develop branch and changed the base from this branch onto develop as well. Profocs main branch always corresponds to the latest CRAN release.

@BerriJ
Copy link
Owner

BerriJ commented Aug 8, 2021

@wenjie2wang Thank you again for this PR.

I just added a quick fix to handle knot_distance > 0.5 which is a special case that we treat differently. Obviously there I no need to create a basis in this case. Further, I added some documentation.

@BerriJ BerriJ merged commit 3ae6118 into BerriJ:develop Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants