From 282d1b144f52f92de7bf405e59343a14a9cb42c6 Mon Sep 17 00:00:00 2001 From: Thomas Turrell-Croft Date: Fri, 3 Feb 2023 13:13:29 +0000 Subject: [PATCH 1/2] Fix scaled value in score is optional --- xapi-model/src/main/java/dev/learning/xapi/model/Score.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xapi-model/src/main/java/dev/learning/xapi/model/Score.java b/xapi-model/src/main/java/dev/learning/xapi/model/Score.java index ee79cce7..7edade36 100644 --- a/xapi-model/src/main/java/dev/learning/xapi/model/Score.java +++ b/xapi-model/src/main/java/dev/learning/xapi/model/Score.java @@ -29,7 +29,7 @@ public class Score { */ @DecimalMax(value = "1.0") @DecimalMin(value = "-1.0") - private float scaled; + private Float scaled; /** * The score achieved by the Actor in the experience described by the Statement. From 45f2ed3764217c2b3336223f907c343927efac67 Mon Sep 17 00:00:00 2001 From: Thomas Turrell-Croft Date: Fri, 3 Feb 2023 13:16:03 +0000 Subject: [PATCH 2/2] tip --- xapi-model/src/main/java/dev/learning/xapi/model/Score.java | 1 + 1 file changed, 1 insertion(+) diff --git a/xapi-model/src/main/java/dev/learning/xapi/model/Score.java b/xapi-model/src/main/java/dev/learning/xapi/model/Score.java index 7edade36..e6021838 100644 --- a/xapi-model/src/main/java/dev/learning/xapi/model/Score.java +++ b/xapi-model/src/main/java/dev/learning/xapi/model/Score.java @@ -24,6 +24,7 @@ @JsonInclude(Include.NON_EMPTY) public class Score { + // TODO check that @DecimalMax and @DecimalMin apply to float /** * The score related to the experience as modified by scaling and/or normalization. */