Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Quest Log: Add the quest start location and image #97

Closed
Bertram25 opened this Issue · 11 comments

3 participants

Yohann Ferreira Nik N shirish
Yohann Ferreira
Owner

Hi,

Since the Quest Log is already looking good and in shape for mass use, I wanted to make it even shinier.

I'd like to be able to set in the quests.lua file:

  • The location name (custom translatable string)
  • The location banner (optional image filename)
  • The quest start image (optional custom image, automatically ratioed to fit at the bottom of the description pan).

Here is a mock-up proposal:
quest-log-mockup

@IkarusDowned What do you think about it?

Nik N

looks cool! shouldn't be too hard, either. can text boxes take formatted / tagging strings?If so, the quest-description stuff is pretty much done. just need to add the image you want into the description string.

Yohann Ferreira
Owner

Ah true. And good idea.

shirish

What do people having a sub-quests kind of thing in there. For e.g. Finding George's Pen should be a sub-quest under the Get Barley Meal.

Also what do people think about giving some xp to the hero when he gets the job done, you can get some part of the inventory introduced there itself ( at least the stats.)

Just an idea.

Yohann Ferreira
Owner

It's a good idea, and we should think about it after adding image and location support.

Yohann Ferreira
Owner

The bottom part is done an in use thanks to @IkarusDowned :)

Nik N

yep, I'm looking at the insert-image thing. shouldn't be too hard, but a couple things that might make it visually un-appealing that I wanted to check with you Bertram:

1) If the text is too long, thent he remaining space may be too small, making the image scale really tiny and look kinda silly
2) In order to prevent (1), do you want me to limit the available text space? I can cap the text box to be at 3/4 the area, and render the image in the remaining 1/4

Yohann Ferreira
Owner

Hi @IkarusDowned

1) If the text is too long, then the remaining space may be too small, making the image scale really tiny and look kinda silly

Completely agree. I "sized" the text to cover something like half of the screen but in fact we might have more lore about this in the end. So the image placement is definitely irrelevant.

2) In order to prevent (1), do you want me to limit the available text space? I can cap the text box to be at 3/4 the area, and render the image in the remaining 1/4

I'd rather add the image to the bottom window, I wondered whether we could reduce the banner by roughly an half (to make it look just not like in other menus with time and drunes, as it might be confusing), and use the space on the right for instance, to display a fixed sized quest image.

Would the banner be cumbersome, I would get rid of it, and have a quest image alone if necessary, but I do think we can manage a way to display the three piece of information (text, banner and quest image) on the bottom and leave the place for the quest text on the middle-right.

Ah, also, not urgent, I'd rather not got in developing a sub-quest system too soon, but I'd like to add an additional quest text when the quest is done, so that the player can have a clue on how he/she did to complete the quest. I realized that when I actually played the games with latest content.

Ah, and many kudos for the new features, just looking like it's commercial and it's mainly thanks to your work. :)

Yohann Ferreira
Owner

Additional question to everyone:

Should I add quest logs for the hide n seek quest, and if so, just one, or one for each hiding spots?

Nik N

I'd rather add the image to the bottom window, I wondered whether we could reduce the banner by roughly an half > (to make it look just not like in other menus with time and drunes, as it might be confusing), and use the space on > the right for instance, to display a fixed sized quest image.

yeah, that shouldn't be a problem. The other option is to just replace the "banner" with a custom image, where appropriate.

Ah, also, not urgent, I'd rather not got in developing a sub-quest system too soon, but I'd like to add an additional
quest text when the quest is done, so that the player can have a clue on how he/she did to complete the quest.

Yep, can do. I'll give you an "AddDescription" function so you can write in whatever you want. Or, do you want it as part of the quest.lua information table? I can add a static field there that just adds onto the description on completion. Which do you prefer?

Also, I'm a bit hesitant on the sub-quest feature at this point. I think its better that we make a "freeze" on new features till the content fills out -- otherwise we are making changes without seeing whether they make aesthetic sense or not. Just my two cents.
That being said, the "adding description" is painless, i can take that

Should I add quest logs for the hide n seek quest, and if so, just one, or one for each hiding spots?

hmm....if you were to do it, i'd say just one entry for hide_n_seek, since the entire quest is to actually play the game...not to find him position after position. Just my two cents :)

Yohann Ferreira
Owner

yeah, that shouldn't be a problem. The other option is to just replace the "banner" with a custom image, where appropriate.

Indeed. I guess in certain case, I'll do that instead. Let's just add the quest image on the right for now. The use of it will tell (and that's something one can later easily tweak, being you or me.)

Or, do you want it as part of the quest.lua information table? I can add a static field there that just adds onto the description on completion. Which do you prefer?

Yeah, the additional entry in the quests table is my favourite. :)

I think its better that we make a "freeze" on new features till the content fills out -- otherwise we are making changes without seeing whether they make aesthetic sense or not. Just my two cents.

Completely agree, let's go to the point of the first full episode I content, stuff to add/fix/beautify will pop up by themselves. And anyway, the sub-quest will deserve a separate issue at least IMHO.

hmm....if you were to do it, i'd say just one entry for hide_n_seek, since the entire quest is to actually play the game...not to find him position after position. Just my two cents :)

Hmm, I was inclined to do that as well but just had a doubt, I must say, so yes, I'll do that.

Nik N IkarusDowned referenced this issue from a commit in IkarusDowned/ValyriaTear
Nik N IkarusDowned Quest Menu Changes
as per #97, a couple remaining quest menu changes

Features:
+ Added location and sub location image / description support
+ Added Completion Descriptions. This is a summary description that shows
up when you complete the quest (in aqua! oooooOOooo....). note that in
order to support this the description text box has been changed from 400px
height to 200px height.

Bug Fix:
- Quest List had some problems with the pointer and "completed" quests. This should now be fixed
- An edge case where a completed quest that had not been read yet was
  causing graphical inconsistencies. This is now fixed
d217eaf
Yohann Ferreira Bertram25 closed this in d60b2e1
Yohann Ferreira
Owner

Done by Ikarus.

Yohann Ferreira Bertram25 referenced this issue from a commit
Nik N IkarusDowned Quest Menu Changes
as per #97, a couple remaining quest menu changes

Features:
+ Added location and sub location image / description support
+ Added Completion Descriptions. This is a summary description that shows
up when you complete the quest (in aqua! oooooOOooo....). note that in
order to support this the description text box has been changed from 400px
height to 200px height.

Bug Fix:
- Quest List had some problems with the pointer and "completed" quests. This should now be fixed
- An edge case where a completed quest that had not been read yet was
  causing graphical inconsistencies. This is now fixed
b42352f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.