Parallel build problem

[AMDmi3]

ISSUE TYPE

• Bug Report

GEEQIE VERSION

1.5.1

OS / DISTRIBUTION

FreeBSD

SUMMARY

Parallel build failure was reported on FreeBSD. Couldn't reproduce it, but as always with parallel build issues it's dependent on a lot of things.

The cause seem to be in src/gq-marshal.{c,h} generation:

geeqie/src/Makefile.am

Lines 304 to 308 in 92b4e3e

	gq-marshal.h: gq-marshal.list
	$(GLIB_GENMARSHAL) --prefix=gq_marshal $(srcdir)/gq-marshal.list --header >$@
	gq-marshal.c: gq-marshal.list gq-marshal.h
	(echo "#include \"gq-marshal.h\"" ; $(GLIB_GENMARSHAL) --prefix=gq_marshal $(srcdir)/gq-marshal.list --body ) >$@

These files must be generated before compiling any sources which reference them, but it doesn't seem to be the case.

STEPS TO REPRODUCE

Try to build geeqie with certain (unknown) number of jobs.

[AMDmi3]

It has been confirmed that my mitigation of this problem, by building gq-marshal.c before the normal build, works.

[caclark]

I am a bit confused... has this been solved elsewhere or is there something that needs doing here to fix this?

[AMDmi3]

It needs to be fixed here, I've just described a hack I've used to patch it in FreeBSD ports.

[caclark]

Fixed, I hope, in commit:
http://geeqie.org/cgi-bin/gitweb.cgi?p=geeqie.git;a=commit;h=881468bec8b73966ce6d3b1c1b9986d9faf1ce22

[AMDmi3]

Thanks, will ask original submitter to test since I cannot reproduce the problem. Btw, it could be more correct to depend on gq-marshal.h here.

[caclark]

be more correct to depend on gq-marshal.h here.

Thanks.

Fixed in commit:
http://www.geeqie.org/cgi-bin/gitweb.cgi?p=geeqie.git;a=commit;h=55ed33bc10771ae7e2929d643cfcedaa8a7f7a27

[AMDmi3]

I've discovered a way to reproduce the problem by adding sleep 1 to gq-marshal.h and gq-marshal.c targets. Either of your changes fixes it, thanks again!