Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Added Maven extensions to build the sample application in one reactor run. #6
The pullrequest contains the following highlevel changes:
It would be great, if we could talk about the target platform generation and the necessary dependencies. Our goal is to just give the update site url from efxclipse and you have the target platform setup.
- just work in progress - just work in progress - deactivated tycho dependency because otherwise there are ClassCastException for the simple BuildEventSpy. -minor changes added gitignore - IMPORTANT: set the tycho dependency to scope "provided" no let the parent classloader load Tycho classes - introduced a new LifecycleParticipant which is executed before the tycho one. That will generate the repo. - new module: maven-osgi-package-support to hold the business logic for creating a local p2-repo. This will be used from other extensions/plugins. - product can be build in two steps. - work in progress - most is working but the P2ApplicationLauncher can not yet be used, because of Classloading issues. Raises a ClastCastException. - works now, but looks like a hack - optimized: activating a profile "create-repo" which should activated the packaging plugin - use system property "tycho.mode=maven" to disable the Tycho lifecycle - new working approach: switch off Tycho Lifecycle, wait for finishing the p2-package plugin, activate the tycho lifecycle with property, get the tycho lifecycle component and start the afterProjectsRead() phase - package plugin can defined as normal and bound to pre-package phase - cleanup - cleanup - removed module maven-osgi-package-support - renaming of the module p2-repo-generator - added comments add build settings - module renamings LEH-14175: added comments LEH-14175: added comments LEH-14175: enhanced the Readme.md LEH-14175: - improved logging if JAR dependency has no Manifest and is no OSGI Bundle LEH-14175: - changed wording LEH-14175: - improved logging for non OSGI bundles - refactored code to check OSGI bundles and support ASCII colors in terminal windows LEH-14175: - improved logging for non OSGI bundles - refactored code to check OSGI bundles and support ASCII colors in terminal windows - changed pom type to maven-plugin for the exec plugin LEH-14591 fixed handling of none "jar" type artifact LEH-14479 Write pathes to config.ini as an URI so that no backslashes will be used -> backslashes are a problem when reading the properties -> they are filtered out LEH-14393 : Added new Project that reads the eclipse feature dependencies and adds it as a maven extension to a poms dependencies LEH-14128: improved maven-osgi-plugins to ignore pom-Artifacts, that avoids errors
Very cool! I'll look at itm later on. Just from the process point of view. Do you by chance have a signed ECA (https://wiki.eclipse.org/ECA).
The reason I ask is that we maybe one day want to fold that work into e(fx)clipse (or some other Eclipse.org project) and it would make the process then easier because all contributions are coming from people who signed the ECA?
tomsontom left a comment
Generally everything looks good (I only looked at the code and have not yet tested it).
I saw that the new code your introduced is living in the de.zeiss namespace. Is this on purpose?