Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign #22

Merged
merged 20 commits into from Dec 11, 2012
Merged

Redesign #22

merged 20 commits into from Dec 11, 2012

Conversation

@rstacruz
Copy link
Collaborator

rstacruz commented Dec 10, 2012

See #6.

image

@rstacruz rstacruz mentioned this pull request Dec 10, 2012
@charliesome

This comment has been minimized.

Copy link
Collaborator

charliesome commented Dec 11, 2012

Holy crap that's beautiful!

I'll play around with it tonight and merge it in. Thanks so much for all the time and effort you've put in to this.

@ndbroadbent

This comment has been minimized.

Copy link
Contributor

ndbroadbent commented Dec 11, 2012

@rstacruz, you are awesome! This is amazing! 👍

@rstacruz

This comment has been minimized.

Copy link
Collaborator Author

rstacruz commented Dec 11, 2012

Would you be interested in code-highlighted var dumps?

image

@charliesome

This comment has been minimized.

Copy link
Collaborator

charliesome commented Dec 11, 2012

What's the performance impact like?

On Tuesday, 11 December 2012 at 4:09 PM, Rico Sta. Cruz wrote:

Would you be interested in code-highlighted var dumps?


Reply to this email directly or view it on GitHub (#22 (comment)).

@rstacruz

This comment has been minimized.

Copy link
Collaborator Author

rstacruz commented Dec 11, 2012

Haven't taken scientific measurements, but it feels okay on my computer

@charliesome

This comment has been minimized.

Copy link
Collaborator

charliesome commented Dec 11, 2012

Perhaps leave it out for the time being and we can add it back in after the new design is merged

@rstacruz

This comment has been minimized.

Copy link
Collaborator Author

rstacruz commented Dec 11, 2012

Agree.

@charliesome

This comment has been minimized.

Copy link
Collaborator

charliesome commented Dec 11, 2012

I've noticed some issues with the custom scrollbar - I'm going to remove the code responsible for that and fall back to the system scroll bar

edit: fixed

@charliesome charliesome merged commit 69a327c into BetterErrors:master Dec 11, 2012
@rolfb

This comment has been minimized.

Copy link

rolfb commented Jun 24, 2013

This is the most awesome pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.