Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the last-raised error, not its "cause" #459

Merged
merged 1 commit into from Apr 18, 2020

Conversation

@RobinDaugherty
Copy link
Member

RobinDaugherty commented Apr 18, 2020

Fixes #296. More discussion in #433.

The change here is to show the most recent exception raised. Previously on Ruby versions supporting Exception#cause it would show the most recent exception's cause if there was one.

The behavior in Rails of showing an "original exception" is still in place. This seems to be a desired behavior that's specific to ActionView template errors in Rails before 5.1.

@RobinDaugherty RobinDaugherty changed the title Show the last error, not its "cause" Show the last-raised error, not its "cause" Apr 18, 2020
@RobinDaugherty RobinDaugherty added this to the v2.7 milestone Apr 18, 2020
@RobinDaugherty RobinDaugherty merged commit 4142e39 into master Apr 18, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@RobinDaugherty RobinDaugherty deleted the feature/show-most-recent-error branch Apr 18, 2020
@sj26
Copy link
Contributor

sj26 commented Apr 19, 2020

Amazing, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.