Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to use lein aliases #279

Merged
merged 7 commits into from Aug 14, 2019
Merged

Possible to use lein aliases #279

merged 7 commits into from Aug 14, 2019

Conversation

@kstehn
Copy link
Contributor

kstehn commented Aug 12, 2019

let the user choose what alias to run when there are any available related to #277

Kevin Stehn and others added 2 commits Aug 12, 2019
@kstehn kstehn requested a review from PEZ Aug 12, 2019
@PEZ

This comment has been minimized.

Copy link
Collaborator

PEZ commented Aug 13, 2019

Nice progress here!

After discussions offline, let me try to summarize what we've concluded:

What to do with main args? (Am I right to assume that main is equivalent to run in Leiningen?).

  • We could try see if the alias has main args/run and if so not provide our own, and if not add our own.
  • We could just never provide our own in the presence of an alias.

Leiningen specific:

  • We need to figure out how we want profiles to work with this. Either aliases+profiles is not supported (as it is now in this branch). Or we try to merge profiles from the alias with whatever the user selects.
  • There need to be an option for ”no alias, please”.
    • Here always let the user select profiles.
  • Calva should remember the aliases selection between jack-ins in the same project.
Kevin Stehn added 2 commits Aug 13, 2019
@kstehn

This comment has been minimized.

Copy link
Contributor Author

kstehn commented Aug 13, 2019

So with the last two commits.

All the Leiningen Specifics should be addressed.
I made it so now that you can choose a alias and profiles if you want too.

For the clj main-args i implemented the second point. Where we dont supply any main if a alias was choosen.

@kstehn kstehn removed the request for review from PEZ Aug 13, 2019
@PEZ

This comment has been minimized.

Copy link
Collaborator

PEZ commented Aug 13, 2019

The Leiningen tests I've done so far seem to work. I'll try to be more creative. 😄

For clj, after testing I see that it can't be unconditional to skip our main. Only if the alias has main args. Jack-in will always fail if there is no main at all.

@kstehn

This comment has been minimized.

Copy link
Contributor Author

kstehn commented Aug 13, 2019

Okay just did it.
I check for the selected aliases if main-opts are available.
If calva does not supply its own main.

@PEZ PEZ merged commit 6189435 into master Aug 14, 2019
@PEZ

This comment has been minimized.

Copy link
Collaborator

PEZ commented Aug 14, 2019

Yeah, so I think this works now.

Nice with those docs telling about what steps are involved in cooking the command lines!

@PEZ PEZ deleted the jack-in-with-aliases branch Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.