Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add myLeinProfiles settings for jack-in #289

Closed
wants to merge 3 commits into from

Conversation

@PEZ
Copy link
Collaborator

commented Aug 19, 2019

Addressing #288 (which is about clj-deps aliases, but I started with Leiningen profiles, just because).

This is one way to do it. It adds a setting myLeinProfiles, which is an array of strings. These strings are then added to the Jack-in quick-pick menu and if selected to the jack-in command at --with-profile. Thus the user needs to specify this ”an extra time”, and risk getting it wrong.

Another way to do it would be to read ~/.lein/profiles.clj, ~/.clojure/deps.edn and populate from there. But it is more work to get it right on all various operating systems and setups, and also would maybe pick up a lot of aliases/profiles, that don't make sense...

This is more KISS, I would say. What say you?

@kstehn

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

I think it is fine to do this for now.
I didnt found any API from vscode to get the home folder.
Otherwise i would just use the home folder and path.join to get the correct path to both files.
This should also be then os save :)

@PEZ

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 19, 2019

I'll go ahead with using settings then. I suspect there is a reason clojure has a command line option to report which config file it is using...

There is also that all aliases and profiles might not make sense for jack-in. I have Sean Corfield's :new alias in my ~/.clojure/deps.edn for instance. Not material for jack-in and would only clutter the menu.

@PEZ

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 3, 2019

I merged this into #285, closing.

@PEZ PEZ closed this Sep 3, 2019

PEZ added a commit that referenced this pull request Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.