Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a hover to results annotation w/ full results #336

Merged
merged 2 commits into from Sep 22, 2019
Merged

Add a hover to results annotation w/ full results #336

merged 2 commits into from Sep 22, 2019

Conversation

@PEZ
Copy link
Collaborator

PEZ commented Sep 22, 2019

This pull request:

Fixes #104, and addresses #79.

Introduces the following change(s):

  • Inline result annotation now have a hover showing the full results.
  • The hover has a Copy link, that copies the results to the clipboard.
  • The inline displayed result takes up less width.

I have:

  • Read How to Contribute.
  • Made sure I am directing this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I am changed the default PR base branch, so that it is not master. (Sorry for the nagging.)
  • Referenced the issue I am fixing/addressing.
  • Updated the [Unrleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.

Ping: @kstehn

PEZ added 2 commits Sep 22, 2019
Fixes #104
Closes #79
@PEZ

This comment has been minimized.

Copy link
Collaborator Author

PEZ commented Sep 22, 2019

Looks like so:

image

@kstehn

This comment has been minimized.

Copy link
Contributor

kstehn commented Sep 22, 2019

Just tested this and works good.
I guess compiling error will get better when the PR #330 gets merged.

From my side it is good to go.

@PEZ

This comment has been minimized.

Copy link
Collaborator Author

PEZ commented Sep 22, 2019

Compiling error?

@PEZ

This comment has been minimized.

Copy link
Collaborator Author

PEZ commented Sep 22, 2019

Ah, I see. Yeah, we should merge that as well, and Marc can file a new issue if it doesn't fix his use case.

@kstehn

This comment has been minimized.

Copy link
Contributor

kstehn commented Sep 22, 2019

Something like this
image

@PEZ PEZ merged commit dfca36e into dev Sep 22, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
@PEZ PEZ deleted the wip/results-hover branch Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.