Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readme #33

Merged
merged 7 commits into from
Jan 3, 2022
Merged

Improve readme #33

merged 7 commits into from
Jan 3, 2022

Conversation

haesleinhuepf
Copy link
Member

@haesleinhuepf haesleinhuepf commented Dec 21, 2021

Description

Hi Johannes @jo-mueller ,
CC Marcelo @zoccoler

in response to #32 I'm just sending an update to the readme. This readme will be shown on pypi and thus, I'm convinced that it should look good. Let me know what you think and if you think it's ok, feel free to merge and publish on pypi.

Also, after merging and publishing on pypi, please

  • check if all links are working,
  • if the figures are shown and
  • make Marcelo and myself co-owners of the repository on pypi, so that we could publish releases as well, just in case.

Type of change

  • Bug-fix
  • New feature
  • Breaking change
  • Documentation update

References

closes #32

Tests

  • I adapted existing tests, because
  • I added new tests to cover the code change
  • All tests pass with my change

Documentation

  • I rebuilt the documentation page to ensure building the pages works
  • I used PEP-8 conformal code styling

Final checks

  • My change is the minimal possible work for the desired feature/fix
  • I updated the documentation where necessary to cover the change

@jo-mueller
Copy link
Contributor

Hi Robert @haesleinhuepf ,

This readme will be shown on pypi and thus, I'm convinced that it should look good.

I totally agree. I made some minor changes to the text. I think in future releases we could talk about what should be documented where (Readme.md vs. gh-pages) but I think for now this is the perfect opener to show at a glance what can be done.

@jo-mueller jo-mueller merged commit 068aa28 into main Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release and publish
2 participants