Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use poster.jpg/banner.jpg breaks some plugins #129

Closed
MartijnKaijser opened this issue Dec 24, 2011 · 6 comments
Closed

use poster.jpg/banner.jpg breaks some plugins #129

MartijnKaijser opened this issue Dec 24, 2011 · 6 comments

Comments

@MartijnKaijser
Copy link
Contributor

When you set 'use poster.jpg/banner.jpg' it breaks the displaying of images for one of our plugins.

Is this normal behaviour?

@MartijnKaijser
Copy link
Contributor Author

I found out that the Apple Trailer Plug-in shows the posters in-depended of what setting you have.
Is there any special coding you did so it works for the apple trailers because i can't really find any obvious reason why it works for that one and not for ours?

@BigNoid
Copy link
Owner

BigNoid commented Jan 4, 2012

No not really. It's just that AMT is set to use content(movies) and there it's always poster thumb. If you have episodes or tv show content then it comes to play.
Is there an easy way for me to test?

@MartijnKaijser
Copy link
Contributor Author

Here's a .zip file containing necessary files and guiding readme file what goes where.
(~100 mb)
http://www.zshare.net/download/98550565d45f6bac/

@MartijnKaijser
Copy link
Contributor Author

small nudge ;)

@BigNoid
Copy link
Owner

BigNoid commented Mar 6, 2012

I know what the problem is now, but I'm not sure I want to fix it. I have to do a substring on every poster/banner thumb to see if the path is not a plugin.video. For example with showcase that would kill the browsing experience because of the extra visibility conditions

@MartijnKaijser
Copy link
Contributor Author

Then that's a no go then :) Don't want to ruin the smoothness of Nox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants