Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image #18

Closed
p3lim opened this issue Aug 4, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@p3lim
Copy link
Collaborator

commented Aug 4, 2018

Would you be opposed to keeping a Dockerfile in this repo and setting up automatic updates for an "official" Docker image?
This would simplify (and speed up) running the packager on CIs using Docker like CircleCI.

I could create the Dockerfile (and even provide a sample config for CircleCI) and help set up the automation with Docker Hub for the image (I could also manage this, but that would require collaboration access to the repo).

I've got this set up locally already, but it'll require manually updating the Docker image every time the script changes, which is what I'm trying to get rid of.

@nebularg

This comment has been minimized.

Copy link
Member

commented Aug 4, 2018

Go for it 😄 I invited you as a collaborator

@p3lim p3lim closed this in ce3c0d8 Aug 4, 2018

@p3lim

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 4, 2018

Just waiting for approval on the link to Docker Hub, I guess you got the mail.

@nebularg

This comment has been minimized.

Copy link
Member

commented Aug 4, 2018

Org level access monkaS

@p3lim

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 4, 2018

https://hub.docker.com/r/p3lim/wow-packager/

Gonna make sure I get CircleCI right and I'll paste a sample config for that too.

@p3lim

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 4, 2018

CircleCI config to run release.sh on tags, using the Docker image:

version: 2
jobs:
  release:
    docker:
      - image: p3lim/wow-packager:latest
    steps:
      - checkout
      - run: release.sh
workflows:
  version: 2
  release:
    jobs:
      - release:
          filters:
            tags:
              only: /.*/
            branches:
              ignore: /.*/

Full docs on this: https://circleci.com/docs/2.0/#adding-a-yml-file

TL;DR:

  1. Create .circleci/config.yml, pasting the above snippet
  2. Add the project on CircleCI dashboard
  3. Add environment variables with API keys on the CircleCI dashboard
  4. Push tag to repo to build

Alternative to step 3 if you've got multiple repositories/addons, use contexts instead, a bit more convenient but more advanced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.