In testing bevy_seedling recently, I noticed my input_processing.rs example appeared to be silent. Checking the graph, everything was connected correctly, so it seems to be an upstream issue. I noticed that commit 8a6066d introduced basic silence-detection for graph inputs, but it appears to read from ch before the input is actually copied to it!
Aside from the oversight, I assume the intent was to avoid the potential cost of copying a silent buffer over. Given the API, however, I suspect it's faster to copy it over anyway since we'll want to immediately check the whole thing to see if it's silent. At least for my purposes, unconditionally copying the buffer and then checking for silence appears to resolve the issue.
In testing
bevy_seedlingrecently, I noticed myinput_processing.rsexample appeared to be silent. Checking the graph, everything was connected correctly, so it seems to be an upstream issue. I noticed that commit 8a6066d introduced basic silence-detection for graph inputs, but it appears to read fromchbefore the input is actually copied to it!Aside from the oversight, I assume the intent was to avoid the potential cost of copying a silent buffer over. Given the API, however, I suspect it's faster to copy it over anyway since we'll want to immediately check the whole thing to see if it's silent. At least for my purposes, unconditionally copying the buffer and then checking for silence appears to resolve the issue.