new audio backend API#107
Merged
Merged
Conversation
Owner
Author
|
I managed to remove the drop ordering requirement! As a bonus, you can now deactivate a Firewheel context without manually dropping the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the clunky
AudioBackendtrait.The only small catch is that the user must make sure that the
CpalStreamis dropped before theFirewheelContextis dropped. But this is a worthwhile tradeoff IMO.I also realized that the
audio_clockmethods in the context don't really make sense when thescheduled_eventsfeature is disabled, so I went ahead and feature-gated those methods too.