Skip to content

Sampler speed#42

Merged
BillyDM merged 10 commits into
mainfrom
sampler_speed
Apr 25, 2025
Merged

Sampler speed#42
BillyDM merged 10 commits into
mainfrom
sampler_speed

Conversation

@BillyDM

@BillyDM BillyDM commented Apr 22, 2025

Copy link
Copy Markdown
Owner

No description provided.

@CorvusPrudens

Copy link
Copy Markdown
Contributor

Alright, I finally had a moment to check this out.

It looks great! It should be nice and easy for users.

I haven't looked into it at all, so take this for what it's worth, but could the max_speed limitation be removed? That is, instead of allocating buffers large enough to fit the maximum speed, could it just fill up the scratch buffers and take multiple passes if necessary?

I imagine this might be a bit less performant, but it would certainly use less memory! I'm also not sure if this would make other resampling techniques more difficult.

@BillyDM

BillyDM commented Apr 24, 2025

Copy link
Copy Markdown
Owner Author

Oh yeah, you're right, I could do that. I'll look into it.

@BillyDM

BillyDM commented Apr 25, 2025

Copy link
Copy Markdown
Owner Author

Ok, I removed the max_speed limitation by using the scratch buffers instead.

@BillyDM BillyDM merged commit 3f36791 into main Apr 25, 2025
3 checks passed
BillyDM added a commit that referenced this pull request May 23, 2025
@BillyDM BillyDM deleted the sampler_speed branch August 1, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants