Add FreeverbNode#78
Merged
Merged
Conversation
piedoom
reviewed
Oct 5, 2025
Contributor
Author
|
Okay, I've tested the node in context, and after the updates it continues to work as expected. I did make some changes to the |
76e01f3 to
cda3a02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a simple reverb node using the freeverb algorithm.
The implementation I pulled this from uses
f64s internally, but we could swap them out forf32, likely without any real loss in quality.The processor has proper smoothing for its parameters, performs declicking when paused, and does a crude silence analysis when its inputs are silent. It appeared to be working correctly in my testing, but I haven't done a full test with the code in Firewheel. I'll report back when I've finished that testing.