Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
changes an error message in case of empty file #896
This PR changes an error message if bap is using with an empty file:
- the error message is wrong, as "executables, libraries, and kernel modules" are not formats, moreover whatever we expect is defined by the loaders, so we can't claim this.
- the fix affects only llvm, while bap-elf and ida loader behavior will remain the same (whatever it was)
- the error message could be made nicer (since you're already here)
- the handling of the problem is wrong - you have an empty file, not an unsupported format.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.