Skip to content

fail_silently defaults to nil #4

Closed
bbck opened this Issue Dec 10, 2011 · 1 comment

2 participants

@bbck
bbck commented Dec 10, 2011

The fail_silently accessor is not set to false by default and no exceptions are raised unless it is explicitly set.

Commenting out line 116 in spec/unit/battlenet_spec.rb I would except would not cause the test to fail.

@BinaryMuse BinaryMuse pushed a commit that closed this issue Dec 10, 2011
Brandon Tilley Correctly set default attributes on Battlenet. Fixes #4. 01d70ed
@BinaryMuse
Owner

Nice catch, bbck, thanks! This has been fixed in v1.1.1, which has been deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.