New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad cursor visibility, especially when surrounded by current bracketMatch styling #189

Closed
darsain opened this Issue Feb 19, 2018 · 5 comments

Comments

5 participants
@darsain

darsain commented Feb 19, 2018

Problem: Find the cursor.

image

I suggest these colors:

"editorCursor.foreground": "#fff",
"editorBracketMatch.border": "#0000",
"editorBracketMatch.background": "#fff1",

Result:

image

@Binaryify

This comment has been minimized.

Show comment
Hide comment
@Binaryify

Binaryify Feb 24, 2018

Owner

you can add this code in your setting

"workbench.colorCustomizations": {
    "editorCursor.foreground": "#e7e5ec"
  },

image

Owner

Binaryify commented Feb 24, 2018

you can add this code in your setting

"workbench.colorCustomizations": {
    "editorCursor.foreground": "#e7e5ec"
  },

image

@bsvipas

This comment has been minimized.

Show comment
Hide comment
@bsvipas

bsvipas Mar 5, 2018

@darsain for me cursor visibility is good so this is kinda personal preference and I see no point to change it.

bsvipas commented Mar 5, 2018

@darsain for me cursor visibility is good so this is kinda personal preference and I see no point to change it.

@Or3stis

This comment has been minimized.

Show comment
Hide comment
@Or3stis

Or3stis Mar 11, 2018

Contributor

I use this color value #528bff for my cursor. It is the same one as in Atom. It improves the visibility.

Before
screen shot 2018-03-11 at 13 54 58

After (cursor value #528bff)
screen shot 2018-03-11 at 13 54 18

Should I make a PR?

Contributor

Or3stis commented Mar 11, 2018

I use this color value #528bff for my cursor. It is the same one as in Atom. It improves the visibility.

Before
screen shot 2018-03-11 at 13 54 58

After (cursor value #528bff)
screen shot 2018-03-11 at 13 54 18

Should I make a PR?

@svipben

This comment has been minimized.

Show comment
Hide comment
@svipben

svipben Mar 11, 2018

Contributor

@Or3stis You're right in Atom cursor color is: #528bff. I will create a PR, thanks a lot @Or3stis.

Contributor

svipben commented Mar 11, 2018

@Or3stis You're right in Atom cursor color is: #528bff. I will create a PR, thanks a lot @Or3stis.

@svipben

This comment has been minimized.

Show comment
Hide comment
@svipben

svipben Mar 11, 2018

Contributor

Done in this PR: #205

Contributor

svipben commented Mar 11, 2018

Done in this PR: #205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment